Re: Review Request 50421: Added code to detect proper zookeeper home directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/#review167355 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Aug. 4, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50421/ > --- > > (Updated Aug. 4, 2016, 8:49 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5905 > https://issues.apache.org/jira/browse/MESOS-5905 > > > Repository: mesos > > > Description > --- > > Added code to detect proper zookeeper home directory. > > > Diffs > - > > src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 > > > Diff: https://reviews.apache.org/r/50421/diff/2/ > > > Testing > --- > > cmake && make > > test with autotools to make sure the tests run. > > > Thanks, > > Srinivas Brahmaroutu > >
Re: Review Request 50421: Added code to detect proper zookeeper home directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/#review144861 --- Patch looks great! Reviews applied: [50421] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 4, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50421/ > --- > > (Updated Aug. 4, 2016, 8:49 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5905 > https://issues.apache.org/jira/browse/MESOS-5905 > > > Repository: mesos > > > Description > --- > > Added code to detect proper zookeeper home directory. > > > Diffs > - > > src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 > > Diff: https://reviews.apache.org/r/50421/diff/ > > > Testing > --- > > cmake && make > > test with autotools to make sure the tests run. > > > Thanks, > > Srinivas Brahmaroutu > >
Re: Review Request 50421: Added code to detect proper zookeeper home directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/ --- (Updated Aug. 4, 2016, 8:49 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Changes --- This path is required to handle the new installation structure with cmake builds. Earlier on auto tools zookeeper jar would be found at /3rdparty/zookeeper-3.4.8/zookeeper-3.4.8.jar and with cmake build system we have an additional directory structure added like /3rdparty/zookeeper-3.4.8/src/zookeeper-3.4.8/zookeeper-3.4.8.jar. This patch allows to set classpath from any of these locations by looking for both. Bugs: MESOS-5905 https://issues.apache.org/jira/browse/MESOS-5905 Repository: mesos Description (updated) --- Added code to detect proper zookeeper home directory. Diffs (updated) - src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 Diff: https://reviews.apache.org/r/50421/diff/ Testing --- cmake && make test with autotools to make sure the tests run. Thanks, Srinivas Brahmaroutu
Re: Review Request 50421: Added code to detect proper zookeeper home directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/#review143470 --- Patch looks great! Reviews applied: [50421] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 25, 2016, 9:53 p.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50421/ > --- > > (Updated July 25, 2016, 9:53 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5905 > https://issues.apache.org/jira/browse/MESOS-5905 > > > Repository: mesos > > > Description > --- > > Now the zookeper test can extract classpath from zookeeper > libraries under 3rdparty/zookeeper-3.4.8 or > 3rdparty/zookeeper-3.4.8/src/zookeeper-3.4.8. > > > Diffs > - > > src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 > > Diff: https://reviews.apache.org/r/50421/diff/ > > > Testing > --- > > cmake && make > > test with autotools to make sure the tests run. > > > Thanks, > > Srinivas Brahmaroutu > >
Re: Review Request 50421: Added code to detect proper zookeeper home directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/ --- (Updated July 25, 2016, 9:53 p.m.) Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5905 https://issues.apache.org/jira/browse/MESOS-5905 Repository: mesos Description (updated) --- Now the zookeper test can extract classpath from zookeeper libraries under 3rdparty/zookeeper-3.4.8 or 3rdparty/zookeeper-3.4.8/src/zookeeper-3.4.8. Diffs - src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 Diff: https://reviews.apache.org/r/50421/diff/ Testing --- cmake && make test with autotools to make sure the tests run. Thanks, Srinivas Brahmaroutu
