Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review160339
---



Patch looks great!

Reviews applied: [50629]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 30, 2016, 6 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50629/
> ---
> 
> (Updated July 30, 2016, 6 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Deshi Xiao.
> 
> 
> Bugs: MESOS-5186
> https://issues.apache.org/jira/browse/MESOS-5186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fix updated the requirement in `python/interface/setup.py.in`
> so that protobuf 3.0 is allowed.
> 
> 
> Diffs
> -
> 
>   src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
> 
> Diff: https://reviews.apache.org/r/50629/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Deshi Xiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review160272
---



good for me.

- Deshi Xiao


On 七月 30, 2016, 6 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50629/
> ---
> 
> (Updated 七月 30, 2016, 6 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Deshi Xiao.
> 
> 
> Bugs: MESOS-5186
> https://issues.apache.org/jira/browse/MESOS-5186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fix updated the requirement in `python/interface/setup.py.in`
> so that protobuf 3.0 is allowed.
> 
> 
> Diffs
> -
> 
>   src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
> 
> Diff: https://reviews.apache.org/r/50629/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Yong Tang]

> On July 30, 2016, 5:36 p.m., haosdent huang wrote:
> > support/mesos-style.py, line 20
> > 
> >
> > I think we forgot update this since we update bundle dependencies last 
> > time. May you post this in a sperate patch? Need update according to 
> > current `*.tar.gz` under `3rdparty`.

Thanks haosdent. Another review request:
https://reviews.apache.org/r/50630/
has been created separately to cover the mesos-style.py changes.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review144266
---


On July 30, 2016, 6 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50629/
> ---
> 
> (Updated July 30, 2016, 6 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Deshi Xiao.
> 
> 
> Bugs: MESOS-5186
> https://issues.apache.org/jira/browse/MESOS-5186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fix updated the requirement in `python/interface/setup.py.in`
> so that protobuf 3.0 is allowed.
> 
> 
> Diffs
> -
> 
>   src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
> 
> Diff: https://reviews.apache.org/r/50629/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/
---

(Updated July 30, 2016, 6 p.m.)


Review request for mesos, haosdent huang and Deshi Xiao.


Changes
---

Split excluded_files in mesos-style.py to Review Request 50630 
(https://reviews.apache.org/r/50630/)


Bugs: MESOS-5186
https://issues.apache.org/jira/browse/MESOS-5186


Repository: mesos


Description
---

This fix updated the requirement in `python/interface/setup.py.in`
so that protobuf 3.0 is allowed.


Diffs (updated)
-

  src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 

Diff: https://reviews.apache.org/r/50629/diff/


Testing
---

make check (Ubuntu 14.04)


Thanks,

Yong Tang

Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/
---

Review request for mesos, haosdent huang and Deshi Xiao.


Bugs: MESOS-5186
https://issues.apache.org/jira/browse/MESOS-5186


Repository: mesos


Description
---

This fix updated the requirement in `python/interface/setup.py.in`
so that protobuf 3.0 is allowed.


Diffs
-

  src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50629/diff/


Testing
---

make check (Ubuntu 14.04)


Thanks,

Yong Tang