Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

2016-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50673/#review152609 --- Ship it! With the cleanups in (

Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

2016-10-13 Thread Joseph Wu
> On Aug. 2, 2016, 4:03 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os/rmdir_tests.cpp, lines 116-117 > > > > > > Since these two sets are only modified once within the test, why not do: > > ``` > >

Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

2016-08-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50673/#review144547 --- 3rdparty/stout/tests/os/rmdir_tests.cpp (line 105)

Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

2016-08-01 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50673/ --- Review request for mesos, Daniel Pravat and Joseph Wu. Bugs: MESOS-5942