Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-26 Thread Vinod Kone
> On Aug. 26, 2016, 9:34 p.m., Vinod Kone wrote: > > i'll fix these while committing. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/#review147027

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/#review147027 --- Fix it, then Ship it! CHANGELOG (line 1)

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-25 Thread Neil Conway
> On Aug. 22, 2016, 7:43 p.m., Vinod Kone wrote: > > src/master/metrics.hpp, lines 183-184 > > > > > > can you add this to the CHANGELOG for 1.1 under "Deprecations" section? Done. Note that I haven't yet attempted

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- (Updated Aug. 25, 2016, 9:09 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- (Updated Aug. 24, 2016, 3:42 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- (Updated Aug. 24, 2016, 3:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/#review146419 --- Fix it, then Ship it! docs/monitoring.md (line 362)

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- (Updated Aug. 12, 2016, 12:32 a.m.) Review request for mesos and Vinod Kone.

Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049