Re: Review Request 50707: Added test for race between health checks and agent disconnect.

2016-09-13 Thread Neil Conway
> On Sept. 12, 2016, 9:27 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, lines 2869-2872 > > > > > > It's not clear to me what we are checking to verify that master behaves > > correctly here? What would

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

2016-09-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/#review148592 --- Fix it, then Ship it! src/tests/slave_tests.cpp (line 2810)

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

2016-09-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Sept. 7, 2016, 9:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

2016-09-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Sept. 7, 2016, 10:54 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

2016-09-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Sept. 7, 2016, 10:37 a.m.) Review request for mesos and Vinod Kone.