Re: Review Request 50836: Made add/subtract resource object as private method.

2016-09-06 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-09-06 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-09-06 Thread Jiang Yan Xu
> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-30 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-30 Thread Jiang Yan Xu
> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/#review146622 --- Patch looks great! Reviews applied: [50836] Passed command:

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-23 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-23 Thread Jiang Yan Xu
> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-23 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/ --- (Updated 八月 23, 2016, 10:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-17 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-17 Thread Jiang Yan Xu
> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-16 Thread Guangya Liu
> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

2016-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/#review144914 --- Patch looks great! Reviews applied: [50836] Passed command:

Review Request 50836: Made add/subtract resource object as private method.

2016-08-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Repository: mesos