Re: Review Request 51323: Supported provisioner provision() and destroy() to be nested aware.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51323/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and Kevin Klues. Bugs: MESOS-6067 https://issues.apache.org/jira/browse/MESOS-6067 Repository: mesos Description --- This patch makes the provisioner provision() and destory() methods to be multi-level nested aware, by simply change the helper function getContainerDir() to be recursive: 1. In provisioner provision(), just need to make sure the rootfs returned from getContainerRootfsDir() and the backend dir returned from getBackendDir() are correctly nested. 2. In provisioner destroy(), need to simply make sure the rootfs from getContainerRootfsDir() is correctly nested. Both getContainerRootfsDir() and getBackendDir() rely on the helper method getContainerDir(). So we can simply make them nested aware by change getContainerDir() to be recursive. Diffs (updated) - src/slave/containerizer/mesos/provisioner/paths.hpp 9829d6b52c8547ae22297a5bc47852ce5a219e4c src/slave/containerizer/mesos/provisioner/paths.cpp 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb Diff: https://reviews.apache.org/r/51323/diff/ Testing (updated) --- make check Thanks, Gilbert Song
Re: Review Request 51323: Supported provisioner provision() and destroy() to be nested aware.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51323/#review146679 --- Ship it! Ship It! - Jie Yu On Aug. 23, 2016, 8:05 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51323/ > --- > > (Updated Aug. 23, 2016, 8:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > --- > > This patch makes the provisioner provision() and destory() methods > to be multi-level nested aware, by simply change the helper function > getContainerDir() to be recursive: > > 1. In provisioner provision(), just need to make sure the rootfs >returned from getContainerRootfsDir() and the backend dir >returned from getBackendDir() are correctly nested. > 2. In provisioner destroy(), need to simply make sure the rootfs >from getContainerRootfsDir() is correctly nested. > > Both getContainerRootfsDir() and getBackendDir() rely on > the helper method getContainerDir(). So we can simply make them > nested aware by change getContainerDir() to be recursive. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/paths.hpp > 9829d6b52c8547ae22297a5bc47852ce5a219e4c > src/slave/containerizer/mesos/provisioner/paths.cpp > 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb > > Diff: https://reviews.apache.org/r/51323/diff/ > > > Testing > --- > > > Thanks, > > Gilbert Song > >
Review Request 51323: Supported provisioner provision() and destroy() to be nested aware.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51323/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and Kevin Klues. Bugs: MESOS-6067 https://issues.apache.org/jira/browse/MESOS-6067 Repository: mesos Description --- This patch makes the provisioner provision() and destory() methods to be multi-level nested aware, by simply change the helper function getContainerDir() to be recursive: 1. In provisioner provision(), just need to make sure the rootfs returned from getContainerRootfsDir() and the backend dir returned from getBackendDir() are correctly nested. 2. In provisioner destroy(), need to simply make sure the rootfs from getContainerRootfsDir() is correctly nested. Both getContainerRootfsDir() and getBackendDir() rely on the helper method getContainerDir(). So we can simply make them nested aware by change getContainerDir() to be recursive. Diffs - src/slave/containerizer/mesos/provisioner/paths.hpp 9829d6b52c8547ae22297a5bc47852ce5a219e4c src/slave/containerizer/mesos/provisioner/paths.cpp 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb Diff: https://reviews.apache.org/r/51323/diff/ Testing --- Thanks, Gilbert Song
