Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-30 Thread Anindya Sinha
> On Aug. 29, 2016, 7:26 a.m., Anindya Sinha wrote: > > I think we should also bring back this function: > > `const hashmap& total()`. > > Jiang Yan Xu wrote: > Why? The total is now fully hidden and we only need to reply on it within > DRFSorter for shared resources. >

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-29 Thread Jiang Yan Xu
> On Aug. 29, 2016, 12:26 a.m., Anindya Sinha wrote: > > I think we should also bring back this function: > > `const hashmap& total()`. > > Jiang Yan Xu wrote: > Why? The total is now fully hidden and we only need to reply on it within > DRFSorter for shared resources.

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-29 Thread Jiang Yan Xu
> On Aug. 29, 2016, 12:26 a.m., Anindya Sinha wrote: > > I think we should also bring back this function: > > `const hashmap& total()`. Why? The total is now fully hidden and we only need to reply on it within DRFSorter for shared resources. - Jiang Yan

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/#review147118 --- I think we should also bring back this function: `const

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-26 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/#review147062 --- Ship it! Ship It! - Anindya Sinha On Aug. 26, 2016, 10:53

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/#review147058 --- Patch looks great! Reviews applied: [51470] Passed command:

Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/ --- Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, and