Re: Review Request 51505: Replace http::get with http::request in mesos project.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51505/#review167404
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Aug. 30, 2016, 5:36 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51505/
> ---
> 
> (Updated Aug. 30, 2016, 5:36 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4440
> https://issues.apache.org/jira/browse/MESOS-4440
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace http::get with http::request in mesos project.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 28cd3fa66886dbdbae3fdeca77707147faafcb7a 
>   src/tests/executor_http_api_tests.cpp 
> fd322ee267b2f0d4bf250db15027d61f1fc74a57 
>   src/tests/fault_tolerance_tests.cpp 
> 5a9944cf459ab688907d95bbda09f464b37efd1e 
>   src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 
>   src/tests/gc_tests.cpp f3aec4a95ff231bed1283ef1408101c012cadea1 
>   src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 
>   src/tests/logging_tests.cpp 886dcd0d6d6ccf509c98578e8b86b1c6ecd5775f 
>   src/tests/master_authorization_tests.cpp 
> a6399f1b958705b87418b40d3771b25a37d49682 
>   src/tests/master_maintenance_tests.cpp 
> 0820e637b0da69ebcfc8776c223c3bc8a4f1bc94 
>   src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
>   src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 
>   src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 266c2a0ff4a99baa96a7c4980f076755603256a9 
>   src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd 
>   src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
>   src/tests/scheduler_driver_tests.cpp 
> faf2e6c8ad17e07964b4340d0b340654b03f9086 
>   src/tests/scheduler_http_api_tests.cpp 
> 80a2ef0af9a4c67deaef40e1f36343868ee4428f 
>   src/tests/slave_authorization_tests.cpp 
> 6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
>   src/tests/status_update_manager_tests.cpp 
> 38d8913a5b33aa5325d0bc632c0a1d80480eddf8 
>   src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 
> 
> 
> Diff: https://reviews.apache.org/r/51505/diff/3/
> 
> 
> Testing
> ---
> 
> make & make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 51505: Replace http::get with http::request in mesos project.

2016-10-18 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51505/#review153044
---




src/tests/executor_http_api_tests.cpp (lines 310 - 312)


Please, if there are multiple layers of function nesting, wrap after the 
`=` so we can see them all lined up properly.


- Adam B


On Aug. 29, 2016, 10:36 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51505/
> ---
> 
> (Updated Aug. 29, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4440
> https://issues.apache.org/jira/browse/MESOS-4440
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace http::get with http::request in mesos project.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 28cd3fa66886dbdbae3fdeca77707147faafcb7a 
>   src/tests/executor_http_api_tests.cpp 
> fd322ee267b2f0d4bf250db15027d61f1fc74a57 
>   src/tests/fault_tolerance_tests.cpp 
> 5a9944cf459ab688907d95bbda09f464b37efd1e 
>   src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 
>   src/tests/gc_tests.cpp f3aec4a95ff231bed1283ef1408101c012cadea1 
>   src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 
>   src/tests/logging_tests.cpp 886dcd0d6d6ccf509c98578e8b86b1c6ecd5775f 
>   src/tests/master_authorization_tests.cpp 
> a6399f1b958705b87418b40d3771b25a37d49682 
>   src/tests/master_maintenance_tests.cpp 
> 0820e637b0da69ebcfc8776c223c3bc8a4f1bc94 
>   src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
>   src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 
>   src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 266c2a0ff4a99baa96a7c4980f076755603256a9 
>   src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd 
>   src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
>   src/tests/scheduler_driver_tests.cpp 
> faf2e6c8ad17e07964b4340d0b340654b03f9086 
>   src/tests/scheduler_http_api_tests.cpp 
> 80a2ef0af9a4c67deaef40e1f36343868ee4428f 
>   src/tests/slave_authorization_tests.cpp 
> 6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
>   src/tests/status_update_manager_tests.cpp 
> 38d8913a5b33aa5325d0bc632c0a1d80480eddf8 
>   src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 
> 
> Diff: https://reviews.apache.org/r/51505/diff/
> 
> 
> Testing
> ---
> 
> make & make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 51505: Replace http::get with http::request in mesos project.

2016-08-29 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51505/
---

(Updated Aug. 30, 2016, 5:36 a.m.)


Review request for mesos.


Changes
---

Code refactor.


Bugs: MESOS-4440
https://issues.apache.org/jira/browse/MESOS-4440


Repository: mesos


Description
---

Replace http::get with http::request in mesos project.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
28cd3fa66886dbdbae3fdeca77707147faafcb7a 
  src/tests/executor_http_api_tests.cpp 
fd322ee267b2f0d4bf250db15027d61f1fc74a57 
  src/tests/fault_tolerance_tests.cpp 5a9944cf459ab688907d95bbda09f464b37efd1e 
  src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 
  src/tests/gc_tests.cpp f3aec4a95ff231bed1283ef1408101c012cadea1 
  src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 
  src/tests/logging_tests.cpp 886dcd0d6d6ccf509c98578e8b86b1c6ecd5775f 
  src/tests/master_authorization_tests.cpp 
a6399f1b958705b87418b40d3771b25a37d49682 
  src/tests/master_maintenance_tests.cpp 
0820e637b0da69ebcfc8776c223c3bc8a4f1bc94 
  src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
  src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 
  src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e 
  src/tests/persistent_volume_endpoints_tests.cpp 
266c2a0ff4a99baa96a7c4980f076755603256a9 
  src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd 
  src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
  src/tests/scheduler_driver_tests.cpp faf2e6c8ad17e07964b4340d0b340654b03f9086 
  src/tests/scheduler_http_api_tests.cpp 
80a2ef0af9a4c67deaef40e1f36343868ee4428f 
  src/tests/slave_authorization_tests.cpp 
6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 
  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
  src/tests/status_update_manager_tests.cpp 
38d8913a5b33aa5325d0bc632c0a1d80480eddf8 
  src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 

Diff: https://reviews.apache.org/r/51505/diff/


Testing
---

make & make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 51505: Replace http::get with http::request in mesos project.

2016-08-29 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51505/
---

(Updated Aug. 30, 2016, 5:28 a.m.)


Review request for mesos.


Summary (updated)
-

Replace http::get with http::request in mesos project.


Bugs: MESOS-4440
https://issues.apache.org/jira/browse/MESOS-4440


Repository: mesos


Description (updated)
---

Replace http::get with http::request in mesos project.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
28cd3fa66886dbdbae3fdeca77707147faafcb7a 
  src/tests/executor_http_api_tests.cpp 
fd322ee267b2f0d4bf250db15027d61f1fc74a57 
  src/tests/fault_tolerance_tests.cpp 5a9944cf459ab688907d95bbda09f464b37efd1e 
  src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 
  src/tests/gc_tests.cpp f3aec4a95ff231bed1283ef1408101c012cadea1 
  src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 
  src/tests/logging_tests.cpp 886dcd0d6d6ccf509c98578e8b86b1c6ecd5775f 
  src/tests/master_authorization_tests.cpp 
a6399f1b958705b87418b40d3771b25a37d49682 
  src/tests/master_maintenance_tests.cpp 
0820e637b0da69ebcfc8776c223c3bc8a4f1bc94 
  src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
  src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 
  src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e 
  src/tests/persistent_volume_endpoints_tests.cpp 
266c2a0ff4a99baa96a7c4980f076755603256a9 
  src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd 
  src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
  src/tests/scheduler_driver_tests.cpp faf2e6c8ad17e07964b4340d0b340654b03f9086 
  src/tests/scheduler_http_api_tests.cpp 
80a2ef0af9a4c67deaef40e1f36343868ee4428f 
  src/tests/slave_authorization_tests.cpp 
6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 
  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
  src/tests/status_update_manager_tests.cpp 
38d8913a5b33aa5325d0bc632c0a1d80480eddf8 
  src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650 

Diff: https://reviews.apache.org/r/51505/diff/


Testing
---

make & make check successfully!


Thanks,

Yongqiao Wang