Re: Review Request 51992: Fixed a bug in getRootContainerId due to protobuf copying issue.

2016-09-17 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51992/#review149347
---


Ship it!




Ship It!

- Kevin Klues


On Sept. 17, 2016, 9:25 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51992/
> ---
> 
> (Updated Sept. 17, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It looks like protobuf is not so great dealing with nesting messages
> when doing merge or copy. This patch uses an extra copy to bypass that
> issue in the protobuf.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/utils.hpp 
> 2bb55c19bcbfcdfff15930d0f9e437a502ce6624 
> 
> Diff: https://reviews.apache.org/r/51992/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 51992: Fixed a bug in getRootContainerId due to protobuf copying issue.

2016-09-17 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51992/
---

Review request for mesos, Gilbert Song and Kevin Klues.


Repository: mesos


Description
---

It looks like protobuf is not so great dealing with nesting messages
when doing merge or copy. This patch uses an extra copy to bypass that
issue in the protobuf.


Diffs
-

  src/slave/containerizer/mesos/utils.hpp 
2bb55c19bcbfcdfff15930d0f9e437a502ce6624 

Diff: https://reviews.apache.org/r/51992/diff/


Testing
---

make check


Thanks,

Jie Yu