Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 1:51 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 1:53 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153999 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016,

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 12:14 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 12:05 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 12:03 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 27, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153994 --- src/tests/health_check_tests.cpp (lines 1636 - 1637)

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review153989 --- src/tests/health_check_tests.cpp (line 1388)

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 21, 2016, 11:12 a.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152884 --- Ship it! LGTM - Gastón Kleiman On Oct. 17, 2016, 2:52 p.m.,

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 17, 2016, 2:38 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

> On Oct. 13, 2016, 3:04 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp, line 1516 > > > > > > This test is flaky, because the master will sometimes not listen on > > 127.0.0.1. > > > >

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152553 --- src/tests/health_check_tests.cpp (line 1516)

Re: Review Request 52250: Added test cases for HTTP health check.

> On Oct. 13, 2016, 1:18 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp, line 1506 > > > > > > Shouldn't this test also use netcat? I moved this comment to the right RR. - Gastón

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152509 --- src/tests/health_check_tests.cpp (line 1516)

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152490 --- src/tests/health_check_tests.cpp (line 1506)

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 12, 2016, 2:37 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 11, 2016, 6:20 a.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 7, 2016, 2:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 5, 2016, 6:10 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 5, 2016, 5:27 p.m.) Review request for mesos, Alexander