Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 1:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Nov. 18, 2016, 4:24 p.m.) Review request for mesos, James Peach,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, line 21 > > > > > > `#include ` My fault, I have no idea why I decided to add a .h at the time :) - Aaron

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 17, 2016, 9:01 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 253-254 > > > > > > Do you happen to know what the request body length has to do with > > `CHAR_MAX` in the first

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Nov. 7, 2016, 4:45 p.m.) Review request for mesos, James Peach,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 2, 2016, 11:52 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 290 > > > > > > I think using an `off_t` for a size is semantically incorrect; I'd stay > > with `size_t`. This

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 2, 2016, 10:52 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 290 > > > > > > I think using an `off_t` for a size is semantically incorrect; I'd stay > > with `size_t`. This

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Nov. 2, 2016, 10:52 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 290 > > > > > > I think using an `off_t` for a size is semantically incorrect; I'd stay > > with `size_t`. This

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review154530 --- Fix it, then Ship it! 3rdparty/libprocess/src/decoder.hpp

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review154439 --- Ship it! Ship It! - James Peach On Oct. 27, 2016, 4:51

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 27, 2016, 4:51 p.m.) Review request for mesos, James Peach,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > > > > > Can you just make ``length`` type ``ssize_t``? > > Aaron Wood wrote: > `length` is

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > > > > > Can you just make ``length`` type ``ssize_t``? > > Aaron Wood wrote: > `length` is

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > > > > > Can you just make ``length`` type ``ssize_t``? `length` is `ssize_t` (set on line 235) -

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 291 > > > > > > It's not obvious to me that this is the right change since the > > surrounding code tries to deal with

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review153024 --- 3rdparty/libprocess/src/encoder.hpp (line 291)

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 14, 2016, 3:14 p.m.) Review request for mesos, Michael Park and