Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-14 Thread Kevin Klues
> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 25 > > > > > > Couple of questions here: > > > > * This seems useful for POSIX platforms, but I don't really

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-14 Thread Alex Clemmer
> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 25 > > > > > > Couple of questions here: > > > > * This seems useful for POSIX platforms, but I don't really

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/ --- (Updated Oct. 13, 2016, 12:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 17 > > > > > > How much work is it to do this now? If we're going to have a dedicated > > header, I would greatly

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 28 > > > > > > I've been out of the game awhile-- are we wrapping comments at 70 > > characters these days? I

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152196 --- 3rdparty/stout/include/stout/wait.hpp (line 17)

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152185 --- 3rdparty/stout/include/stout/wait.hpp (line 14)

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152184 --- Can you update 3rdparty/stout/include/Makefile.am as well? - Jie

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152183 --- Ship it! Ship It! - Jie Yu On Oct. 10, 2016, 9:22 p.m.,

Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6310