Re: Review Request 52727: Added `Labels` to docker image.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52727/ --- (Updated δΈζ 7, 2017, 11:33 a.m.) Review request for mesos, Benjamin Mahler and Kevin Klues. Changes --- rebase Bugs: MESOS-5967 https://issues.apache.org/jira/browse/MESOS-5967 Repository: mesos Description --- Added `Labels` to docker image. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd Diff: https://reviews.apache.org/r/52727/diff/ Testing --- make make check ``` ./bin/mesos-tests.sh --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from DockerImageTest [ RUN ] DockerImageTest.ParseInspectonImage [ OK ] DockerImageTest.ParseInspectonImage (4 ms) [--] 1 test from DockerImageTest (4 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (21 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu
Re: Review Request 52727: Added `Labels` to docker image.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52727/ --- (Updated εζ 11, 2016, 12:56 p.m.) Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-5967 https://issues.apache.org/jira/browse/MESOS-5967 Repository: mesos Description --- Added `Labels` to docker image. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e src/tests/containerizer/docker_tests.cpp 2f4e84ac10a00d59aa0b979055d5669ced4c895e Diff: https://reviews.apache.org/r/52727/diff/ Testing --- make make check ``` ./bin/mesos-tests.sh --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from DockerImageTest [ RUN ] DockerImageTest.ParseInspectonImage [ OK ] DockerImageTest.ParseInspectonImage (4 ms) [--] 1 test from DockerImageTest (4 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (21 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu
Review Request 52727: Added `Labels` to docker image.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52727/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-5967 https://issues.apache.org/jira/browse/MESOS-5967 Repository: mesos Description --- Added `Labels` to docker image. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e src/tests/containerizer/docker_tests.cpp 2f4e84ac10a00d59aa0b979055d5669ced4c895e Diff: https://reviews.apache.org/r/52727/diff/ Testing --- make make check ``` ./bin/mesos-tests.sh --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from DockerImageTest [ RUN ] DockerImageTest.ParseInspectonImage [ OK ] DockerImageTest.ParseInspectonImage (4 ms) [--] 1 test from DockerImageTest (4 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (21 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu
