Re: Review Request 52735: Updated comment message for docker killing.

[Yubo Li]

> On 十一月 12, 2016, 11:39 a.m., Guangya Liu wrote:
> > What about update the summary and description as following? 
> > 
> > Summary:
> > ```
> > Updated comments for killing some garbage containers.
> > ```
> > 
> > Description:
> > ```
> > We have already enabled `Garbage collector` for some garbage
> > containers (failed to be killed when destroy), so the related
> > comments should be updated to reflect this.
> > ```

fixed


- Yubo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/#review155776
---


On 十一月 10, 2016, 8:13 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52735/
> ---
> 
> (Updated 十一月 10, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `Garbage collector` has already enabled so that the docker failed
> in killing will be force removed by calling `Self::remove`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> Diff: https://reviews.apache.org/r/52735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 52735: Updated comment message for docker killing.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/#review155776
---



What about update the summary and description as following? 

Summary:
```
Updated comments for killing some garbage containers.
```

Description:
```
We have already enabled `Garbage collector` for some garbage
containers (failed to be killed when destroy), so the related
comments should be updated to reflect this.
```


src/slave/containerizer/docker.cpp (lines 2176 - 2179)


I think this should be right before #2167


- Guangya Liu


On 十一月 10, 2016, 8:13 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52735/
> ---
> 
> (Updated 十一月 10, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `Garbage collector` has already enabled so that the docker failed
> in killing will be force removed by calling `Self::remove`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> Diff: https://reviews.apache.org/r/52735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 52735: Updated comment message for docker killing.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/
---

(Updated Nov. 10, 2016, 8:13 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Summary (updated)
-

Updated comment message for docker killing.


Repository: mesos


Description (updated)
---

`Garbage collector` has already enabled so that the docker failed
in killing will be force removed by calling `Self::remove`.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 

Diff: https://reviews.apache.org/r/52735/diff/


Testing
---


Thanks,

Yubo Li