Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Vinod Kone
> On Oct. 12, 2016, 10:56 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 734 > > > > > > I think this should call `_shutdown()` to ensure ShutdownProcess is > > spawned whenever we want to shutdown. >

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Anand Mazumdar
> On Oct. 12, 2016, 10:56 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 734 > > > > > > I think this should call `_shutdown()` to ensure ShutdownProcess is > > spawned whenever we want to shutdown. T

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/#review152414 --- src/executor/executor.cpp (line 731)

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/#review152283 --- Patch looks great! Reviews applied: [52755, 52756] Passed comman

Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6370 https://issues.ap