Re: Review Request 52814: Added note to CHANGELOG about --runtime_dir.

2016-10-14 Thread Kevin Klues


> On Oct. 15, 2016, 12:08 a.m., Vinod Kone wrote:
> > CHANGELOG, line 18
> > 
> >
> > I would move this to "Additional API Changes" section since that's 
> > where we have been calling out important flags changes.

Got it. Will do next time.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/#review152764
---


On Oct. 15, 2016, 12:04 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52814/
> ---
> 
> (Updated Oct. 15, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6312
> https://issues.apache.org/jira/browse/MESOS-6312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note to CHANGELOG about --runtime_dir.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 11e361b22254a7f892f5fa6b656480caf859d9ec 
> 
> Diff: https://reviews.apache.org/r/52814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 52814: Added note to CHANGELOG about --runtime_dir.

2016-10-14 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/#review152764
---


Fix it, then Ship it!





CHANGELOG (line 18)


I would move this to "Additional API Changes" section since that's where we 
have been calling out important flags changes.


- Vinod Kone


On Oct. 15, 2016, 12:04 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52814/
> ---
> 
> (Updated Oct. 15, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-6312
> https://issues.apache.org/jira/browse/MESOS-6312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note to CHANGELOG about --runtime_dir.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 11e361b22254a7f892f5fa6b656480caf859d9ec 
> 
> Diff: https://reviews.apache.org/r/52814/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 52814: Added note to CHANGELOG about --runtime_dir.

2016-10-14 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52814/
---

(Updated Oct. 15, 2016, 12:04 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and 
Vinod Kone.


Changes
---

Updated to only change the CHANGELOG since we introduce 
https://reviews.apache.org/r/52902/ to fix the underlying issue.


Summary (updated)
-

Added note to CHANGELOG about --runtime_dir.


Bugs: MESOS-6312
https://issues.apache.org/jira/browse/MESOS-6312


Repository: mesos


Description (updated)
---

Added note to CHANGELOG about --runtime_dir.


Diffs (updated)
-

  CHANGELOG 11e361b22254a7f892f5fa6b656480caf859d9ec 

Diff: https://reviews.apache.org/r/52814/diff/


Testing
---


Thanks,

Kevin Klues