Re: Review Request 52848: Cleaned up style in stout rmdir_tests.cpp.

2016-10-14 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52848/#review152718
---


Ship it!




Ship It!

- Alex Clemmer


On Oct. 13, 2016, 11:48 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52848/
> ---
> 
> (Updated Oct. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, Joris Van Remoortere, 
> and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Change a few test variables to `const` and made use of initializer lists
> as these variables are only modified once at the beginning of the tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> ffe234baac305e26b5a29cffcdd310350d10167e 
> 
> Diff: https://reviews.apache.org/r/52848/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> Windows:
> msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:stout_tests
> 
> On an Administrator CmdPrompt:
> "3rdparty/stout/tests/Debug/stout_tests.exe"
> ```
> [ RUN  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink
> C:\mesos\3rdparty\stout\tests\os\rmdir_tests.cpp(285): error: 
> fs::symlink("tmp", link): '_stat' failed on path 'C:\tmp\vehk5d\tmp': No such 
> file or directory
> [  FAILED  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink (4 ms)
> 
> [--] Global test environment tear-down
> [==] 187 tests from 32 test cases ran. (2445 ms total)
> [  PASSED  ] 185 tests.
> [  FAILED  ] 2 tests, listed below:
> [  FAILED  ] NetTest.LinkDevice
> [  FAILED  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink
> ```
> ^ That was failing before; no change in this review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 52848: Cleaned up style in stout rmdir_tests.cpp.

2016-10-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52848/#review152639
---



Patch looks great!

Reviews applied: [50673, 52848]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 13, 2016, 11:48 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52848/
> ---
> 
> (Updated Oct. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, Joris Van Remoortere, 
> and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Change a few test variables to `const` and made use of initializer lists
> as these variables are only modified once at the beginning of the tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> ffe234baac305e26b5a29cffcdd310350d10167e 
> 
> Diff: https://reviews.apache.org/r/52848/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> Windows:
> msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:stout_tests
> 
> On an Administrator CmdPrompt:
> "3rdparty/stout/tests/Debug/stout_tests.exe"
> ```
> [ RUN  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink
> C:\mesos\3rdparty\stout\tests\os\rmdir_tests.cpp(285): error: 
> fs::symlink("tmp", link): '_stat' failed on path 'C:\tmp\vehk5d\tmp': No such 
> file or directory
> [  FAILED  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink (4 ms)
> 
> [--] Global test environment tear-down
> [==] 187 tests from 32 test cases ran. (2445 ms total)
> [  PASSED  ] 185 tests.
> [  FAILED  ] 2 tests, listed below:
> [  FAILED  ] NetTest.LinkDevice
> [  FAILED  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink
> ```
> ^ That was failing before; no change in this review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 52848: Cleaned up style in stout rmdir_tests.cpp.

2016-10-13 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52848/
---

Review request for mesos, Daniel Pravat, Alex Clemmer, Joris Van Remoortere, 
and Jiang Yan Xu.


Repository: mesos


Description
---

Change a few test variables to `const` and made use of initializer lists
as these variables are only modified once at the beginning of the tests.


Diffs
-

  3rdparty/stout/tests/os/rmdir_tests.cpp 
ffe234baac305e26b5a29cffcdd310350d10167e 

Diff: https://reviews.apache.org/r/52848/diff/


Testing
---

make check (OSX)

Windows:
msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:stout_tests

On an Administrator CmdPrompt:
"3rdparty/stout/tests/Debug/stout_tests.exe"
```
[ RUN  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink
C:\mesos\3rdparty\stout\tests\os\rmdir_tests.cpp(285): error: 
fs::symlink("tmp", link): '_stat' failed on path 'C:\tmp\vehk5d\tmp': No such 
file or directory
[  FAILED  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink (4 ms)

[--] Global test environment tear-down
[==] 187 tests from 32 test cases ran. (2445 ms total)
[  PASSED  ] 185 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] NetTest.LinkDevice
[  FAILED  ] RmdirTest.RemoveDirectoryWithNoTargetSymbolicLink
```
^ That was failing before; no change in this review.


Thanks,

Joseph Wu