Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-11-02 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Nov. 2, 2016, 9:03 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-11-02 Thread Qian Zhang
> On Nov. 2, 2016, 1:22 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, lines 158-159 > > > > > > This sounds pretty hacky to me. What if there are multiple 'rootfs' > > along

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-11-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/#review154513 --- Fix it, then Ship it!

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-11-01 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Nov. 1, 2016, 2:44 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-11-01 Thread Qian Zhang
> On Oct. 28, 2016, 10:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-29 Thread Jie Yu
> On Oct. 28, 2016, 2:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-29 Thread Jie Yu
> On Oct. 28, 2016, 2:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 213 > > > > > > Hum, IIUC, looks like this is not entirely correct. According to this: > > > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-29 Thread Qian Zhang
> On Oct. 28, 2016, 10:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-28 Thread Jie Yu
> On Oct. 28, 2016, 2:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 213 > > > > > > Hum, IIUC, looks like this is not entirely correct. According to this: > > > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-28 Thread Jie Yu
> On Oct. 28, 2016, 2:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-28 Thread Qian Zhang
> On Oct. 28, 2016, 10:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 213 > > > > > > Hum, IIUC, looks like this is not entirely correct. According to this: > > > >

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/#review154084 --- src/slave/containerizer/mesos/provisioner/backends/copy.cpp

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-24 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Oct. 25, 2016, 11:47 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Oct. 23, 2016, 1:11 p.m.) Review request for mesos and Jie Yu.

Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

2016-10-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6360