Re: Review Request 53124: Add documentation on Windows support

2016-11-01 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review154472
---


Fix it, then Ship it!





docs/windows.md (lines 61 - 62)


Our markdown renderer doesn't transform this into a list unless there is a 
newline in between here.

I'll add it before committing.



docs/windows.md (line 68)


"Notes" are usually added like: `**NOTE**:`.  I can fix this.


- Joseph Wu


On Oct. 31, 2016, 2:49 p.m., Lior Zeno wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> ---
> 
> (Updated Oct. 31, 2016, 2:49 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds documentation on Windows support in Mesos.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 69e8da5 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-31 Thread Lior Zeno 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/
---

(Updated Oct. 31, 2016, 9:49 p.m.)


Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description (updated)
---

This patch adds documentation on Windows support in Mesos.


Diffs (updated)
-

  docs/getting-started.md 69e8da5 
  docs/home.md f47f7f9 
  docs/windows.md PRE-CREATION 

Diff: https://reviews.apache.org/r/53124/diff/


Testing
---


Thanks,

Lior Zeno

Re: Review Request 53124: Add documentation on Windows support

2016-10-31 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review154318
---



New docs should try to keep lines under 80 characters.

This can't be done in the case of URLs though, so you can leave those as is.

---

I added a bunch of suggestions and more details you can put in the doc.  You 
can probably remove the `WIP` from your description in your next update.


docs/getting-started.md (line 29)


Not yours, but can your correct the grammar on the first sentence to:
```
The Mesos agent also runs
```

And s/To build Mesos agent/To build Mesos/



docs/windows.md (line 63)


s/Due to Windows/Due to the 260 character/
^ perhaps append a `on Windows` in the first part of the sentence, if it 
flows better.



docs/windows.md (lines 64 - 66)


Indent by 2 spaces.



docs/windows.md (line 65)


s/be as four/be up to/



docs/windows.md (line 68)


This is almost entirely due to symlinks (i.e. in the sandbox directories, 
we symlink the `ContainerID` to `latest`).  

On Windows, this requires Admin... :(



docs/windows.md (lines 70 - 71)


These three points (plus the `MesosContainerizer` point) are related.

Isolation is not supported on the MesosContainerizer on Windows.  Depending 
on the APIs Windows exposes for Windows Containers, this might be supported in 
future though...

We will eventually support isolation via the DockerContainerizer (e.g. 
Windows Containers), but only on specific Windows versions.


- Joseph Wu


On Oct. 29, 2016, 4:35 a.m., Lior Zeno wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> ---
> 
> (Updated Oct. 29, 2016, 4:35 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 69e8da5 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review154215
---



Patch looks great!

Reviews applied: [53124]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 29, 2016, 11:35 a.m., Lior Zeno wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> ---
> 
> (Updated Oct. 29, 2016, 11:35 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 69e8da5 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-29 Thread Lior Zeno 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/
---

(Updated Oct. 29, 2016, 11:35 a.m.)


Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

This patch adds documentation on Windows support in Mesos.
Currently considered a WIP, published in order to receive inital feedback.


Diffs (updated)
-

  docs/getting-started.md 69e8da5 
  docs/home.md f47f7f9 
  docs/windows.md PRE-CREATION 

Diff: https://reviews.apache.org/r/53124/diff/


Testing
---


Thanks,

Lior Zeno

Re: Review Request 53124: Add documentation on Windows support

2016-10-28 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review154174
---



Also consider watching this:
https://www.youtube.com/watch?v=bbyK1EBxrek=27=PLGeM09tlguZQVL7ZsfNMffX9h1rGNVqnC

Many of the limitations discussed there are still applicable.


docs/windows.md (line 8)


Considering how different the two getting-started pages are (lots of manual 
steps), I'd actually like to move the content over here.  You can leave a link 
in the getting-started page to this file.



docs/windows.md (line 12)


Nit: s/Linux/Posix/



docs/windows.md (line 13)


Micro-nit: s/launcher_dir/--launcher_dir/

And backticks around `MAX_PATH`



docs/windows.md (line 14)


Technically, this is due to Marathon appending a UUID (36 characters) onto 
the TaskID.  So an ID of < 40 characters is still possible.


- Joseph Wu


On Oct. 23, 2016, 3:09 p.m., Lior Zeno wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> ---
> 
> (Updated Oct. 23, 2016, 3:09 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -
> 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review153666
---



Patch looks great!

Reviews applied: [53124]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 23, 2016, 10:09 p.m., Lior Zeno wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> ---
> 
> (Updated Oct. 23, 2016, 10:09 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -
> 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>

Re: Review Request 53124: Add documentation on Windows support

2016-10-23 Thread Lior Zeno 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/
---

(Updated Oct. 23, 2016, 10:09 p.m.)


Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.


Summary (updated)
-

Add documentation on Windows support


Repository: mesos


Description
---

This patch adds documentation on Windows support in Mesos.
Currently considered a WIP, published in order to receive inital feedback.


Diffs
-

  docs/home.md f47f7f9 
  docs/windows.md PRE-CREATION 

Diff: https://reviews.apache.org/r/53124/diff/


Testing
---


Thanks,

Lior Zeno