Re: Review Request 53541: Added authorization actions for debug API.

2016-11-28 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 28, 2016, 5:34 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-28 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 28, 2016, 2:18 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 23, 2016, 2:42 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-23 Thread Alexander Rojas
> On Nov. 17, 2016, 10:44 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.proto, line 160 > > > > > > Since LNC, KillNC, and WaitNC already exist, could you wire up the > > authorization check for

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review156709 --- include/mesos/authorizer/acls.proto (line 271)

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 22, 2016, 3:48 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-22 Thread Alexander Rojas
> On Nov. 17, 2016, 10:44 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, lines 386-387 > > > > > > Is this really proper indentation for a Mesos protobuf? Doesn't look > > like we've had to wrap

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 21, 2016, 5:25 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-16 Thread Alexander Rojas
> On Nov. 16, 2016, 7:14 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.proto, lines 142-143 > > > > > > What are these exceptional cases? What is an authorizer supposed to do > > with no object

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review156027 --- include/mesos/authorizer/authorizer.proto (lines 142 - 143)

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review155426 --- Patch looks great! Reviews applied: [52600, 53057, 53058, 53541]

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-08 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review155390 --- Can you add the stubs for the handlers that do proper

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 8, 2016, 4:43 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 8, 2016, 4:43 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

2016-11-08 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review155387 --- Can you add a link to MESOS-6474 in the Bugs field? - Kevin

Review Request 53541: Added authorization actions for debug API.

2016-11-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- Review request for mesos, Adam B, Kapil Arya, Kevin Klues, and Till Toenshoff.