Re: Review Request 53713: Reversed recoursive path creation.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53713/#review167529
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 14, 2016, 5:44 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53713/
> ---
> 
> (Updated Nov. 14, 2016, 5:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows the user to use different
> path formats. Specialy on Windows will allow to
> specify `X:\PATH`, '\\foo\bar\PATH`, `\\?\X:\PATH`
> and other valid path.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/mkdir.hpp 
> fe86864c8b480993c8f052f39b2fd3ece23798da 
> 
> 
> Diff: https://reviews.apache.org/r/53713/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 53713: Reversed recoursive path creation.

2016-12-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53713/#review159634
---




3rdparty/stout/include/stout/os/mkdir.hpp (lines 45 - 47)


On Windows, we need to handle paths like:
```
C:\
C:\foo
\foo\bar
\?\C:\
\?\C:\foo
```

If we're going to add logic for all these path prefixes, we should consider 
splitting up `mkdir.hpp` into platform specific files.


- Joseph Wu


On Nov. 13, 2016, 9:44 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53713/
> ---
> 
> (Updated Nov. 13, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows the user to use different
> path formats. Specialy on Windows will allow to
> specify `X:\PATH`, '\\foo\bar\PATH`, `\\?\X:\PATH`
> and other valid path.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/mkdir.hpp 
> fe86864c8b480993c8f052f39b2fd3ece23798da 
> 
> Diff: https://reviews.apache.org/r/53713/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Review Request 53713: Reversed recoursive path creation.

2016-11-13 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53713/
---

Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph 
Wu, and Michael Park.


Repository: mesos


Description
---

This change allows the user to use different
path formats. Specialy on Windows will allow to
specify `X:\PATH`, '\\foo\bar\PATH`, `\\?\X:\PATH`
and other valid path.


Diffs
-

  3rdparty/stout/include/stout/os/mkdir.hpp 
fe86864c8b480993c8f052f39b2fd3ece23798da 

Diff: https://reviews.apache.org/r/53713/diff/


Testing
---


Thanks,

Daniel Pravat