Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/ --- (Updated Dec. 16, 2016, 6:21 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/#review159131 --- Patch looks great! Reviews applied: [54720, 54727] Passed

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/#review159096 --- Ship it! Ship It! - Anand Mazumdar On Dec. 14, 2016, 12:46

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-13 Thread Anand Mazumdar
> On Dec. 14, 2016, 1:34 a.m., Anand Mazumdar wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, lines 91-115 > > > > > > hmm, I imagine us having a client for the Operator API in the future. > > If it has

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-13 Thread Vinod Kone
> On Dec. 14, 2016, 1:34 a.m., Anand Mazumdar wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, lines 91-115 > > > > > > hmm, I imagine us having a client for the Operator API in the future. > > If it has

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/#review159088 --- LGTM, minus a comment around the helper function naming.

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/#review159084 --- Ship it! Ship It! - Kevin Klues On Dec. 14, 2016, 12:46

Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

2016-12-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/ --- Review request for mesos, Anand Mazumdar and Kevin Klues. Repository: mesos