Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2017-02-05 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

(Updated Feb. 5, 2017, 6:27 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Addressed Alex's comments.


Repository: mesos


Description
---

Introduced an `os::pipe` abstraction to stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
68df2ef5cda9416d2d3bfa94f05ac04bf35d663f 
  3rdparty/stout/include/stout/windows/os.hpp 
c123772ab018d327b02dacfb314b835b9f373cfc 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2017-02-05 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/#review164279
---


Fix it, then Ship it!





3rdparty/stout/include/Makefile.am (line 129)


Probably want to line these slashes up?



3rdparty/stout/include/stout/os/windows/pipe.hpp (line 43)


This seems like it should be using `WindowsError` instead? `ErrnoError` is 
usually only for CRT functions, while `WindowsError` also captures win32 error 
codes.


- Alex Clemmer


On Feb. 5, 2017, 1:38 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54762/
> ---
> 
> (Updated Feb. 5, 2017, 1:38 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced an `os::pipe` abstraction to stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
>   3rdparty/stout/include/stout/os.hpp 
> ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
>   3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/posix/os.hpp 
> 68df2ef5cda9416d2d3bfa94f05ac04bf35d663f 
>   3rdparty/stout/include/stout/windows/os.hpp 
> c123772ab018d327b02dacfb314b835b9f373cfc 
> 
> Diff: https://reviews.apache.org/r/54762/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2017-02-04 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

(Updated Feb. 4, 2017, 5:38 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Introduced an `os::pipe` abstraction to stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
68df2ef5cda9416d2d3bfa94f05ac04bf35d663f 
  3rdparty/stout/include/stout/windows/os.hpp 
c123772ab018d327b02dacfb314b835b9f373cfc 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2017-01-09 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

(Updated Jan. 9, 2017, 6:49 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Introduced an `os::pipe` abstraction to stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
397c2d6b06ddb607d254eae8258da5151c5f57e0 
  3rdparty/stout/include/stout/windows/os.hpp 
5cd92545a49648e39e8eb7cf131895e9cfc97902 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2016-12-21 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

(Updated Dec. 21, 2016, 3:37 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Introduced an `os::pipe` abstraction to stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
397c2d6b06ddb607d254eae8258da5151c5f57e0 
  3rdparty/stout/include/stout/windows/os.hpp 
5cd92545a49648e39e8eb7cf131895e9cfc97902 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2016-12-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

(Updated Dec. 20, 2016, 2:31 p.m.)


Review request for mesos.


Summary (updated)
-

Introduced an `os::pipe` abstraction to stout.


Repository: mesos


Description (updated)
---

Introduced an `os::pipe` abstraction to stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
397c2d6b06ddb607d254eae8258da5151c5f57e0 
  3rdparty/stout/include/stout/windows/os.hpp 
5cd92545a49648e39e8eb7cf131895e9cfc97902 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54762: Introduced an os::pipe abstraction to stout.

2016-12-15 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

(Updated Dec. 15, 2016, 5:51 p.m.)


Review request for mesos.


Repository: mesos


Description
---

Introduced an os::pipe abstraction to stout.


Diffs
-

  3rdparty/stout/include/Makefile.am 56c44911ff7015d5825a93ce7a898a60c8624ee7 
  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
05d27a0beacfdd706b0c5c2e5d28465ca3e118fb 
  3rdparty/stout/include/stout/windows/os.hpp 
51c8dcfab135d0323369e4605c67cf6df4a9671e 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park

Review Request 54762: Introduced an os::pipe abstraction to stout.

2016-12-14 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54762/
---

Review request for mesos.


Repository: mesos


Description
---

Introduced an os::pipe abstraction to stout.


Diffs
-

  3rdparty/stout/include/Makefile.am 56c44911ff7015d5825a93ce7a898a60c8624ee7 
  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION 
  3rdparty/stout/include/stout/posix/os.hpp 
05d27a0beacfdd706b0c5c2e5d28465ca3e118fb 
  3rdparty/stout/include/stout/windows/os.hpp 
51c8dcfab135d0323369e4605c67cf6df4a9671e 

Diff: https://reviews.apache.org/r/54762/diff/


Testing
---


Thanks,

Michael Park