Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159950 --- Looks pretty reasonable to me, but I've got a few questions about

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159850 --- Ship it! Confirmed that these changes will fix the tests when

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- (Updated Dec. 20, 2016, 10:32 p.m.) Review request for mesos, Adam B, Andrew

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

> On Dec. 20, 2016, 5:36 p.m., Greg Mann wrote: > > LGTM, thanks Alex! Have you tested these on Windows as well? If so, it > > would be good to include in the "testing" section. I have, but unfortunately, some of these tests have other issues that I need to deal with on Windows before they're

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159732 --- Ship it! LGTM, thanks Alex! Have you tested these on Windows

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

> On Dec. 20, 2016, 12:01 a.m., Greg Mann wrote: > > I was able to catch one flaky test by running the agent tests in > > repetition. For the other patches you're working on, I would recommend > > running the altered tests for a while with `--gtest_repeat=-1 > > --gtest_break_on_failure` to

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- (Updated Dec. 20, 2016, 10:37 a.m.) Review request for mesos, Adam B, Andrew

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159647 --- I was able to catch one flaky test by running the agent tests in

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159599 --- Patch looks great! Reviews applied: [54803] Passed command:

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- (Updated Dec. 17, 2016, 11:01 p.m.) Review request for mesos, Adam B, Andrew

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159531 --- Patch looks great! Reviews applied: [54803] Passed command:

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159484 --- src/tests/slave_tests.cpp (lines 2733 - 2736)

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

> On Dec. 16, 2016, 4:27 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [54803, 54677, 54618, 54611, 53706, 52624, 52625, 52972, > > 52544, 52364] > > > > Failed command: ./support/apply-review.sh -n -r 52544 > > > > Error: > > 2016-12-16 04:26:46

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- (Updated Dec. 16, 2016, 7:23 p.m.) Review request for mesos, Adam B, Andrew

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

> On Dec. 16, 2016, 7:04 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp, lines 2733-2736 > > > > > > In some cases you explicitly advance the clock by the backoff factor, > > while here you resume the clock

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159462 --- src/tests/slave_tests.cpp (lines 2733 - 2736)

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159409 --- Bad patch! Reviews applied: [54803, 54677, 54618, 54611, 53706,

Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- Review request for mesos, Adam B, Andrew Schwartzmeyer, Daniel Pravat, Greg