Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/#review161479 --- Ship it! Sounds good. I'll tweak the error message wording a

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/#review160444 --- Ship it! Ship It! - Alex Clemmer On Jan. 3, 2017, 10:14

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/ --- (Updated Jan. 3, 2017, 10:14 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Alex Clemmer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Alex Clemmer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2017-01-03 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-24 Thread Alex Clemmer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-22 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/#review159803 --- Patch looks great! Reviews applied: [54877] Passed command:

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-20 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-20 Thread Alex Clemmer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-20 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-19 Thread Alex Clemmer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-19 Thread Andrew Schwartzmeyer
> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. What would you convert it to?

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/#review159672 --- 3rdparty/stout/include/stout/windows/os.hpp (line 743)

Review Request 54877: Windows: Stout: Removed dependency on Shell API.

2016-12-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/ --- Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.