Re: Review Request 55269: Avoided use of CHECK macros.

2017-01-10 Thread Benjamin Bannier
> On Jan. 7, 2017, 12:28 a.m., Kapil Arya wrote: > > LGTM. Have you run any tests where the existing `CHECK_SOME` would fail and > > the new code will behave properly? It might be worth running it at least > > for one test. Maybe, in one of the containerizer value, just set it to > >

Re: Review Request 55269: Avoided use of CHECK macros.

2017-01-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55269/ --- (Updated Jan. 10, 2017, 2:19 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 55269: Avoided use of CHECK macros.

2017-01-10 Thread Benjamin Bannier
> On Jan. 7, 2017, 12:28 a.m., Kapil Arya wrote: > > LGTM. Have you run any tests where the existing `CHECK_SOME` would fail and > > the new code will behave properly? It might be worth running it at least > > for one test. Maybe, in one of the containerizer value, just set it to > >

Re: Review Request 55269: Avoided use of CHECK macros.

2017-01-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55269/#review160788 --- LGTM. Have you run any tests where the existing `CHECK_SOME`

Re: Review Request 55269: Avoided use of CHECK macros.

2017-01-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55269/#review160728 --- Patch looks great! Reviews applied: [55268, 55269] Passed

Review Request 55269: Avoided use of CHECK macros.

2017-01-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55269/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-6860