Re: Review Request 55459: Added task check validation test.

2017-01-22 Thread Alexander Rukletsov
> On Jan. 21, 2017, 3:39 p.m., Vinod Kone wrote: > > Still planning to check against the actual strings? I usually tend to avoid this (what you say in the comment), but we can add them. - Alexander --- This is an automatically

Re: Review Request 55459: Added task check validation test.

2017-01-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review162561 --- Ship it! Still planning to check against the actual strings?

Re: Review Request 55459: Added task check validation test.

2017-01-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/ --- (Updated Jan. 20, 2017, 2:50 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55459: Added task check validation test.

2017-01-20 Thread Alexander Rukletsov
> On Jan. 18, 2017, 11:38 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp, line 114 > > > > > > Can you also add a test for valid cases? They are embedded into this test: there are some `EXPECT_NONE`'s. I'll

Re: Review Request 55459: Added task check validation test.

2017-01-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review162086 --- Bad patch! Reviews applied: [55459, 55458, 55457, 55456, 55455,

Re: Review Request 55459: Added task check validation test.

2017-01-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review162073 --- src/tests/check_tests.cpp (line 31)

Re: Review Request 55459: Added task check validation test.

2017-01-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55459: Added task check validation test.

2017-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review161383 --- Bad patch! Reviews applied: [55459, 55458, 55457, 55456, 55455,

Review Request 55459: Added task check validation test.

2017-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.