Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/ --- (Updated Jan. 18, 2017, 2:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-18 Thread Jan Schlicht
> On Jan. 17, 2017, 7:11 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, line 171 > > > > > > I think we need a case insensitive os::getenv because one can use > > `HTTPS_PROXY` as well. > > > > Maybe

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-18 Thread Jan Schlicht
> On Jan. 17, 2017, 7:11 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, line 171 > > > > > > I think we need a case insensitive os::getenv because one can use > > `HTTPS_PROXY` as well. > > > > Maybe

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/#review161893 --- src/uri/fetchers/docker.cpp (line 168)

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/#review161886 --- Patch looks great! Reviews applied: [55496, 55621] Passed

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/ --- (Updated Jan. 17, 2017, 3:53 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

2017-01-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, and Jie Yu. Bugs: