Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-19 Thread Gastón Kleiman
> On Jan. 19, 2017, 2:23 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 4266 > > > > > > we don't do "Times(1)" since that is the default. > > > > just do > > > > ``` > >

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-19 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/ --- (Updated Jan. 19, 2017, 4:19 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/#review162293 --- Fix it, then Ship it! Modulo comments from Vinod.

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/#review162287 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 4256)

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/#review162274 --- Ship it! Ship It! - Alexander Rojas On Jan. 19, 2017, 11:17

Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-19 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/ --- (Updated Jan. 19, 2017, 10:17 a.m.) Review request for mesos, Adam B,

Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.

2017-01-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55677/ --- Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar,