Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review168720 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-12 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 12, 2017, 8:05 a.m.) Review request for mesos, Adam B,

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review168704 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-10 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 10, 2017, 10:16 p.m.) Review request for mesos, Adam B,

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review168433 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-08 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 8, 2017, 11:18 p.m.) Review request for mesos, Adam B,

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-07 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 7, 2017, 11:19 p.m.) Review request for mesos, Adam B,

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review167870 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-03 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 3, 2017, 8:09 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review167592 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-03-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 1, 2017, 4:15 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review167008 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-27 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 28, 2017, 1:18 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166133 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Anindya Sinha
> On Feb. 21, 2017, 12:18 a.m., Jiang Yan Xu wrote: > > Hey looks like slave_authorization_tests.cpp is more suitable place to put > > this test? Fair enough. Moved the test to `slave_authorization_tests.cpp` in the latest update. - Anindya

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 21, 2017, 7:21 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Anindya Sinha
> On Feb. 20, 2017, 7:50 a.m., Jiang Yan Xu wrote: > > src/tests/slave_tests.cpp, line 4965 > > > > > > s/users/user/ `users` is fine since there are 2 users, i.e. `bar` and the current user. - Anindya

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166111 --- Hey looks like slave_authorization_tests.cpp is more suitable

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166035 --- Fix it, then Ship it! src/tests/slave_tests.cpp (lines 4952 -

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review164686 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-07 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 8, 2017, 3:54 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 6, 2017, 11:17 p.m.) Review request for mesos, Adam B, Alexander

Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-01-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- Review request for mesos, Adam B and Jiang Yan Xu. Bugs: MESOS-6953