Re: Review Request 55937: Added constants for referring to request/response streaming headers.

2017-01-27 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55937/#review163341
---


Ship it!




Ship It!

- Vinod Kone


On Jan. 26, 2017, 5:04 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55937/
> ---
> 
> (Updated Jan. 26, 2017, 5:04 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the previous streaming headers and added constants for
> "Message-Accept and "Message-Content-Type" headers allowing us
> to refer to them later in the agent API handlers. Also, modified
> the stream operators as well as the serialize/deserialize
> functions to handle the new content-type.
> 
> 
> Diffs
> -
> 
>   include/mesos/http.hpp fdc4839615159adbc8af61dca7bfdfe5cd69a8b4 
>   src/common/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba 
>   src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe 
> 
> Diff: https://reviews.apache.org/r/55937/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 55937: Added constants for referring to request/response streaming headers.

2017-01-25 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55937/
---

(Updated Jan. 26, 2017, 5:04 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments.


Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936


Repository: mesos


Description
---

Removed the previous streaming headers and added constants for
"Message-Accept and "Message-Content-Type" headers allowing us
to refer to them later in the agent API handlers. Also, modified
the stream operators as well as the serialize/deserialize
functions to handle the new content-type.


Diffs (updated)
-

  include/mesos/http.hpp fdc4839615159adbc8af61dca7bfdfe5cd69a8b4 
  src/common/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba 
  src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe 

Diff: https://reviews.apache.org/r/55937/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 55937: Added constants for referring to request/response streaming headers.

2017-01-25 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55937/#review163050
---




src/common/http.cpp (line 111)


This should be `LOG(FATAL)` instead of `UNREACHABLE` because there is 
nothing stopping someone from calling this function with RECORDIO content type.


- Vinod Kone


On Jan. 25, 2017, 7:47 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55937/
> ---
> 
> (Updated Jan. 25, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the previous streaming headers and added constants for
> "Message-Accept and "Message-Content-Type" headers allowing us
> to refer to them later in the agent API handlers. Also, modified
> the stream operators as well as the serialize/deserialize
> functions to handle the new content-type.
> 
> 
> Diffs
> -
> 
>   include/mesos/http.hpp fdc4839615159adbc8af61dca7bfdfe5cd69a8b4 
>   src/common/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba 
>   src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe 
> 
> Diff: https://reviews.apache.org/r/55937/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 55937: Added constants for referring to request/response streaming headers.

2017-01-25 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55937/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936


Repository: mesos


Description
---

Removed the previous streaming headers and added constants for
"Message-Accept and "Message-Content-Type" headers allowing us
to refer to them later in the agent API handlers. Also, modified
the stream operators as well as the serialize/deserialize
functions to handle the new content-type.


Diffs
-

  include/mesos/http.hpp fdc4839615159adbc8af61dca7bfdfe5cd69a8b4 
  src/common/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba 
  src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe 

Diff: https://reviews.apache.org/r/55937/diff/


Testing
---

make check


Thanks,

Anand Mazumdar