Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165898 --- Ship it! Ship It! - Vinod Kone On Feb. 16, 2017, 5:52 p.m.,

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/ --- (Updated Feb. 16, 2017, 5:52 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165843 --- src/common/validation.cpp (line 113)

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165778 --- Ship it! - Vinod Kone On Feb. 15, 2017, 10:48 p.m., Greg

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 14, 2017, 10:49 p.m., Albert Strasheim wrote: > > include/mesos/mesos.proto, line 1994 > > > > > > I believe pretty strongly that this should be bytes. Discussed with > > Greg. > > > > If I put

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/ --- (Updated Feb. 15, 2017, 10:48 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165587 --- include/mesos/mesos.proto (line 1994)

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 9, 2017, 6:31 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1994 > > > > > > Actually, one thought here. Given that environment varaible's source > > cannot be a byte stream. Do we want to have

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 9, 2017, 6:31 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1994 > > > > > > Actually, one thought here. Given that environment varaible's source > > cannot be a byte stream. Do we want to have

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 9, 2017, 6:31 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1994 > > > > > > Actually, one thought here. Given that environment varaible's source > > cannot be a byte stream. Do we want to have

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 9, 2017, 6:31 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1994 > > > > > > Actually, one thought here. Given that environment varaible's source > > cannot be a byte stream. Do we want to have

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review164960 --- include/mesos/mesos.proto (line 1994)

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review164952 --- Ship it! Ship It! - Jie Yu On Feb. 9, 2017, 6:33 a.m., Greg

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 9, 2017, 9:47 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 1986 > > > > > > And if key is left out, then the entire secret contents are > > returned/used? That's up to the isolator module

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review164884 --- Ship it! LGTM (no new tests though)

Re: Review Request 56052: Added the 'Secret' protobuf message.

> On Feb. 3, 2017, 9:10 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1967-1968 > > > > > > What are these two fields used for? Can you give an example to > > demonstrate the difference between name and

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/ --- (Updated Feb. 9, 2017, 6:33 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review164102 --- include/mesos/mesos.proto (lines 1967 - 1968)

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review163950 --- Ship it! Ship It! - Jan Schlicht On Jan. 31, 2017, 11:44

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review163738 --- Ship it! Ship It! - Vinod Kone On Jan. 31, 2017, 10:44

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/ --- (Updated Jan. 31, 2017, 10:44 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review163710 --- include/mesos/mesos.proto (line 1952)

Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6996