Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-03-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated March 4, 2017, 1:37 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-03-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated March 3, 2017, 11:39 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review167889 --- Fix it, then Ship it! 3rdparty/libprocess/src/authenticator.cp

Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-03-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated March 3, 2017, 6:36 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-03-03 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review167805 --- LGTM 3rdparty/libprocess/include/process/http.hpp Line 106 (orig

Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-02-28 Thread Greg Mann
> On Feb. 27, 2017, 11:58 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp, lines 65-72 > > > > > > I would prefer if either the definition or the whole function could be > > mov

Re: Review Request 56623: Implemented the 'Principal' type in libprocess.

2017-02-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 28, 2017, 6:28 p.m.) Review request for mesos, Adam B, Alexander