Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

2017-02-21 Thread Zhitao Li 


> On Feb. 21, 2017, 11:20 p.m., Zhitao Li wrote:
> > docs/upgrades.md, lines 252-260
> > 
> >
> > 1. Is the order of these actions matter? I recall we specifically say 
> > order of upgrading each component does not mater, so I'm interested in why 
> > this is being explicitly called out;
> > 2. Is this specific to 1.1.x -> 1.2.x upgrade, or serves just a general 
> > guideline regardless of versions? (if former, maybe call out the reason; if 
> > latter, maybe move to a different location).
> 
> Adam B wrote:
> 1. We generally recommend upgrading masters before agents (and rebuilding 
> modules before either).
> 2. This is nothing new to 1.2.x, and is actually included in each 
> release's section (except 1.1.x). The order/recommendation doesn't usually 
> change much, although it has evolved as we have added modules and clarified 
> the need for scheduler/executor upgrades.

Thanks for the clarification.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56867/#review166262
---


On Feb. 21, 2017, 7:57 a.m., Adam B wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56867/
> ---
> 
> (Updated Feb. 21, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade guide for 1.2.x.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 74f4367020d7025bdcfbbf50a166a644ee5050bc 
> 
> Diff: https://reviews.apache.org/r/56867/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam B
> 
>

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

2017-02-21 Thread Adam B 


> On Feb. 21, 2017, 3:20 p.m., Zhitao Li wrote:
> > docs/upgrades.md, lines 252-260
> > 
> >
> > 1. Is the order of these actions matter? I recall we specifically say 
> > order of upgrading each component does not mater, so I'm interested in why 
> > this is being explicitly called out;
> > 2. Is this specific to 1.1.x -> 1.2.x upgrade, or serves just a general 
> > guideline regardless of versions? (if former, maybe call out the reason; if 
> > latter, maybe move to a different location).

1. We generally recommend upgrading masters before agents (and rebuilding 
modules before either).
2. This is nothing new to 1.2.x, and is actually included in each release's 
section (except 1.1.x). The order/recommendation doesn't usually change much, 
although it has evolved as we have added modules and clarified the need for 
scheduler/executor upgrades.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56867/#review166262
---


On Feb. 20, 2017, 11:57 p.m., Adam B wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56867/
> ---
> 
> (Updated Feb. 20, 2017, 11:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade guide for 1.2.x.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 74f4367020d7025bdcfbbf50a166a644ee5050bc 
> 
> Diff: https://reviews.apache.org/r/56867/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam B
> 
>

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

2017-02-21 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56867/#review166262
---




docs/upgrades.md (lines 249 - 257)


1. Is the order of these actions matter? I recall we specifically say order 
of upgrading each component does not mater, so I'm interested in why this is 
being explicitly called out;
2. Is this specific to 1.1.x -> 1.2.x upgrade, or serves just a general 
guideline regardless of versions? (if former, maybe call out the reason; if 
latter, maybe move to a different location).


- Zhitao Li


On Feb. 21, 2017, 7:57 a.m., Adam B wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56867/
> ---
> 
> (Updated Feb. 21, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade guide for 1.2.x.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 74f4367020d7025bdcfbbf50a166a644ee5050bc 
> 
> Diff: https://reviews.apache.org/r/56867/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam B
> 
>

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

2017-02-21 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56867/#review166204
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 21, 2017, 7:57 a.m., Adam B wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56867/
> ---
> 
> (Updated Feb. 21, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade guide for 1.2.x.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 74f4367020d7025bdcfbbf50a166a644ee5050bc 
> 
> Diff: https://reviews.apache.org/r/56867/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam B
> 
>

Re: Review Request 56867: WIP: Added upgrade guide for 1.2.x.

2017-02-21 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56867/#review166140
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Feb. 21, 2017, 7:57 a.m., Adam B wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56867/
> ---
> 
> (Updated Feb. 21, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade guide for 1.2.x.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 74f4367020d7025bdcfbbf50a166a644ee5050bc 
> 
> Diff: https://reviews.apache.org/r/56867/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam B
> 
>

Review Request 56867: WIP: Added upgrade guide for 1.2.x.

2017-02-20 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56867/
---

Review request for mesos.


Repository: mesos


Description
---

Added upgrade guide for 1.2.x.


Diffs
-

  docs/upgrades.md 74f4367020d7025bdcfbbf50a166a644ee5050bc 

Diff: https://reviews.apache.org/r/56867/diff/


Testing
---


Thanks,

Adam B