Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 6, 2017, 4:07 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review168031 --- Fix it, then Ship it! New function names look good.

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 6, 2017, 3:37 a.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Lines 1785-1786 (original), 1789-1793 (patched) > > > > > > It looks like we should have pulled out this rename to into a

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 401-412 (patched) > > > > > > Since this is effectively `stopTrackingAllocationToRole`, should we be > > CHECKing the

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 6, 2017, 2:57 a.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Lines 2652-2654 (patched) > > > > > > Per the other suggestions, perhaps something like: > > > > ``` > > bool

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review167948 --- Couple of high level suggestions: (1) Looks like some patches

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 4, 2017, 7:55 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 4, 2017, 7:31 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 4, 2017, 1:09 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 4, 2017, 11:53 a.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 3, 2017, 6:08 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review167922 --- src/master/master.hpp Lines 1785-1786 (original), 1793-1797

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 2, 2017, 8:26 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Lines 2526 (patched) > > > > > > At this point, you have based it on `info` instead of `source`, right? > > Maybe that's a little

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 2, 2017, 8:26 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Lines 2263 (patched) > > > > > > This last sentence seems a bit redundant? Removed with your suggestion above. > On March 2,

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 3, 2017, 3:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review167880 --- src/master/master.hpp Lines 1785-1786 (original), 1793-1794

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 3, 2017, 1:47 p.m.) Review request for mesos and Benjamin

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On Feb. 27, 2017, 2:25 p.m., Michael Park wrote: > > src/master/master.cpp > > Lines 5992-5993 (patched) > > > > > > Resolve this before committing. Addressed by https://reviews.apache.org/r/57282/ - Michael

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review16 --- src/master/master.hpp Lines 2260-2263 (patched)

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On Feb. 27, 2017, 10:25 p.m., Michael Park wrote: > > src/master/master.hpp > > Lines 2452-2461 (original), 2515-2524 (patched) > > > > > > @bmahler: This allows even non-`MULTI_ROLE` frameworks to change their

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review166954 --- src/master/master.hpp (lines 2515 - 2524)

Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627