Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-04-28 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated April 28, 2017, 2:40 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-04-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated April 26, 2017, 10:53 a.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-04-22 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review172739 --- Ship it! Ship It! - Anindya Sinha On March 28, 2017, 8:24

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review171533 --- Fix it, then Ship it! Nit: unnecessary `break`

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-04-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review171023 --- Ship it! Ship It! - Greg Mann On March 28, 2017, 8:24 a.m.,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-28 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review170275 --- Ship it! Ship It! - Alexander Rojas On March 28, 2017,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-28 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated March 28, 2017, 1:24 a.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-28 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review170270 --- src/authorizer/local/authorizer.cpp Lines 1057-1067 (patched)

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated March 19, 2017, 9:09 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-19 Thread Jiang Yan Xu
> On March 17, 2017, 2:32 p.m., Greg Mann wrote: > > src/tests/authorization_tests.cpp > > Lines 4270 (patched) > > > > > > Could you also add a test case with the ANY subject? This test already covers the subject

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review169323 --- src/authorizer/local/authorizer.cpp Lines 1155 (patched)

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-15 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review169029 --- Ship it! Ship It! - Anindya Sinha On March 15, 2017, 12:40

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-14 Thread Jiang Yan Xu
> On March 14, 2017, 4:05 p.m., Anindya Sinha wrote: > > include/mesos/authorizer/acls.proto > > Line 440 (original), 450 (patched) > > > > > > Not your change, but maybe move that down so the ids are in ascending

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated March 14, 2017, 5:40 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-14 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review168940 --- include/mesos/authorizer/acls.proto Line 440 (original), 450

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated March 14, 2017, 11:17 a.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review168816 --- Bad patch! Reviews applied: [57534, 57520] Failed command:

Review Request 57534: Added and implemented RegisterAgent ACL.

2017-03-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- Review request for mesos, Adam B, Anindya Sinha, and Alexander Rojas. Bugs: