Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review169359 --- src/webui/master/static/roles.html Lines 28-31 (patched)

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review169358 --- Fix it, then Ship it! Ship It!

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-16 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review169246 --- Ship it! Ship It! - Jay Guo On March 16, 2017, 9:28 a.m.,

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-15 Thread Benjamin Mahler
> On March 15, 2017, 10:44 a.m., Jay Guo wrote: > > src/webui/master/static/roles.html > > Lines 30-31 (patched) > > > > > > ``` > > {{role.resources.mem * (1024 * 1024) | dataSize}} > >

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/ --- (Updated March 15, 2017, 9:03 p.m.) Review request for mesos, Jay Guo, Michael

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-15 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review168986 --- src/webui/master/static/roles.html Lines 30-31 (patched)

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-14 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/ --- (Updated March 15, 2017, 2:05 a.m.) Review request for mesos, Jay Guo, Michael

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-14 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review168958 --- src/webui/master/static/roles.html Lines 15 (patched)

Review Request 57622: Introduced a Roles tab in the webui.

2017-03-14 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/ --- Review request for mesos, Jay Guo, Michael Park, and Neil Conway. Bugs: