Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-05-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review173708 --- Ship it! Committing with minor edit.

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-05-02 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- (Updated May 2, 2017, 5:54 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-05-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review173522 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review172745 --- Patch looks great! Reviews applied: [57963, 57964] Passed

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-22 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- (Updated April 22, 2017, 5 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-22 Thread Anindya Sinha
> On April 21, 2017, 10:06 p.m., Jiang Yan Xu wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 1174-1175 (patched) > > > > > > The comment doesn't seem right? Yes, ofcourse. Copy and paste issue. Fixed

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review172689 --- src/tests/persistent_volume_tests.cpp Lines 1174-1175 (patched)

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-03-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review170253 --- Patch looks great! Reviews applied: [57963, 57964] Passed

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-03-27 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- (Updated March 27, 2017, 10:27 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-03-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review170212 --- Patch looks great! Reviews applied: [57963, 57964] Passed

Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-03-27 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7186