Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated June 22, 2017, 2:01 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated June 22, 2017, 1:57 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

> On May 17, 2017, 9:44 a.m., Adam B wrote: > > src/common/http.cpp > > Lines 510-511 (patched) > > > > > > Why is this the only `json()` that nees to be in its type's namespace. > > Does QuotaInfo really need to be

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review175208 --- Re: "Testing Done": Can you point to the unit test that proves we

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

> On April 27, 2017, 7:58 a.m., Alexander Rojas wrote: > > src/master/http.cpp > > Lines 3481-3482 (original), 3456-3457 (patched) > > > > > > Not yours, but I feel the formatting of this lambda is really off. The

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review174540 --- Ship it! Ship It! - Alexander Rojas On May 10, 2017, 6:32 p.

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated May 11, 2017, 12:32 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated May 10, 2017, 9:42 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review174453 --- src/master/http.cpp Lines 3489-3497 (original), 3491-3499 (patche

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review17 --- I really like the shape this is taking. Just a really minor issue

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

> On April 27, 2017, 10:58 p.m., Alexander Rojas wrote: > > src/master/http.cpp > > Line 3401 (original), 3403 (patched) > > > > > > your changes here make this function non safe thread. Notice that the > > origina

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated May 8, 2017, 3:41 p.m.) Review request for mesos, Adam B, Alexander Ro