Re: Review Request 58292: Removed unnecesary break statements in local approver.

2017-04-10 Thread Adam B

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58292/#review171511
---


Ship it!




Ship It!

- Adam B


On April 10, 2017, 3:09 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58292/
> ---
> 
> (Updated April 10, 2017, 3:09 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removes `break` statements located in lines following a `return`
> statement since they are effectively unreachable code, don't improve
> readability nor make the code cleaner.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> e241edf4afa48d35d94d72e8e8690f5bedfc 
> 
> 
> Diff: https://reviews.apache.org/r/58292/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Review Request 58292: Removed unnecesary break statements in local approver.

2017-04-10 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58292/
---

Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.


Repository: mesos


Description
---

Removes `break` statements located in lines following a `return`
statement since they are effectively unreachable code, don't improve
readability nor make the code cleaner.


Diffs
-

  src/authorizer/local/authorizer.cpp e241edf4afa48d35d94d72e8e8690f5bedfc 


Diff: https://reviews.apache.org/r/58292/diff/1/


Testing
---

make check


Thanks,

Alexander Rojas