Re: Review Request 58828: Replaced std::set with hashset for framework roles.

2017-04-28 Thread Benjamin Mahler
> On April 28, 2017, 6:30 a.m., Michael Park wrote: > > It's true that we don't use `std::set` for its ordering in the general case, > > however, I think the ordering does help produce easier-to-read error > > messages. > > > > > > What do you think of preserving that property? Yes you're

Re: Review Request 58828: Replaced std::set with hashset for framework roles.

2017-04-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58828/#review173302 --- Ship it! Ship It! - Michael Park On April 27, 2017, 5:43

Re: Review Request 58828: Replaced std::set with hashset for framework roles.

2017-04-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58828/#review173299 --- It's true that we don't use `std::set` for its ordering in the

Review Request 58828: Replaced std::set with hashset for framework roles.

2017-04-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58828/ --- Review request for mesos and Michael Park. Repository: mesos Description