Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-06-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review177605 --- Ship it! Ship It! - Till Toenshoff On June 2, 2017, 12:25

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-06-02 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/ --- (Updated June 2, 2017, 2:25 p.m.) Review request for mesos, Adam B, Greg Mann,

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-06-01 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review176636 --- src/tests/api_tests.cpp Lines 766 (patched)

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-06-01 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review176620 --- Fix it, then Ship it! src/tests/api_tests.cpp Line 756

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/ --- (Updated May 22, 2017, 5:57 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-17 Thread Alexander Rojas
> On May 17, 2017, 10:51 a.m., Adam B wrote: > > src/master/http.cpp > > Lines 2056 (patched) > > > > > > Should we modify the v0 `/logging/toggle` endpoint to use this > > authorization::action instead of

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review175220 --- Looks pretty good. Just some questions about the v0

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/ --- (Updated May 12, 2017, 11:28 a.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/ --- (Updated May 9, 2017, 5:43 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review173814 --- LGTM. Minor points below. src/tests/api_tests.cpp Lines 741

Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

2017-05-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7414