Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review191281
---


Ship it!




Ship It!

- Gilbert Song


On Nov. 16, 2017, 1:34 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated Nov. 16, 2017, 1:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> d9b1173ad6860ed06e24285551aab9117eddbc96 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/
---

(Updated Nov. 16, 2017, 9:34 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894


Repository: mesos


Description
---

Added tests for recovering ContainerConfig.


Diffs (updated)
-

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
d9b1173ad6860ed06e24285551aab9117eddbc96 


Diff: https://reviews.apache.org/r/59687/diff/5/

Changes: https://reviews.apache.org/r/59687/diff/4-5/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Zhitao Li 


> On Nov. 16, 2017, 7:29 p.m., Gilbert Song wrote:
> > src/tests/containerizer/nested_mesos_containerizer_tests.cpp
> > Lines 1773 (patched)
> > 
> >
> > Did build you test and run it?

Sorry missed this one.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review191230
---


On Nov. 16, 2017, 9:34 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated Nov. 16, 2017, 9:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> d9b1173ad6860ed06e24285551aab9117eddbc96 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review191230
---




src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1773 (patched)


Did build you test and run it?


- Gilbert Song


On Nov. 16, 2017, 9:02 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated Nov. 16, 2017, 9:02 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> d9b1173ad6860ed06e24285551aab9117eddbc96 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/
---

(Updated Nov. 16, 2017, 5:02 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Fix type for returned Future.


Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894


Repository: mesos


Description
---

Added tests for recovering ContainerConfig.


Diffs (updated)
-

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
d9b1173ad6860ed06e24285551aab9117eddbc96 


Diff: https://reviews.apache.org/r/59687/diff/4/

Changes: https://reviews.apache.org/r/59687/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review191156
---


Fix it, then Ship it!





src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1742 (patched)


seems like we just updated it to be `LaunchResult` for standalone container.


- Gilbert Song


On Oct. 27, 2017, 11:02 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated Oct. 27, 2017, 11:02 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-06 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review190241
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 27, 2017, 11:02 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated Oct. 27, 2017, 11:02 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-10-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/
---

(Updated Oct. 27, 2017, 6:02 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Fix format lint.


Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894


Repository: mesos


Description
---

Added tests for recovering ContainerConfig.


Diffs (updated)
-

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 


Diff: https://reviews.apache.org/r/59687/diff/3/

Changes: https://reviews.apache.org/r/59687/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-10-26 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review189351
---


Fix it, then Ship it!





src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1773 (patched)


newline above.



src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1777 (patched)


newline above



src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1788 (patched)


newline below.


- Gilbert Song


On Sept. 26, 2017, 11:14 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated Sept. 26, 2017, 11:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> f8b4423de8a468501336acc5ee0c67f181dc65f5 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-09-26 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/
---

(Updated Sept. 26, 2017, 6:14 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Rebase and remove whitespace at the end of the line.


Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894


Repository: mesos


Description
---

Added tests for recovering ContainerConfig.


Diffs (updated)
-

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
f8b4423de8a468501336acc5ee0c67f181dc65f5 


Diff: https://reviews.apache.org/r/59687/diff/2/

Changes: https://reviews.apache.org/r/59687/diff/1-2/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-09-25 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/#review186192
---


Fix it, then Ship it!




This patch LGTM.


src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1648 (patched)


extra space?


- Gilbert Song


On May 31, 2017, 11 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59687/
> ---
> 
> (Updated May 31, 2017, 11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for recovering ContainerConfig.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> e46643434dc85d766bd549a037f36a89a6738678 
> 
> 
> Diff: https://reviews.apache.org/r/59687/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 59687: Added tests for recovering ContainerConfig.

2017-05-31 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59687/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-6894
https://issues.apache.org/jira/browse/MESOS-6894


Repository: mesos


Description
---

Added tests for recovering ContainerConfig.


Diffs
-

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
e46643434dc85d766bd549a037f36a89a6738678 


Diff: https://reviews.apache.org/r/59687/diff/1/


Testing
---


Thanks,

Zhitao Li