Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-21 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 21, 2017, 11:11 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-21 Thread Megha Sharma
> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5945-5946 (patched) > > > > > > This comment seems to be misplaced, why does the code here cares? It > > just processes the

Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178388 --- PTAL at these comments but I realize for this review it's

Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-15 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 15, 2017, 7:31 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-15 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 15, 2017, 5:53 p.m.) Review request for mesos, Neil Conway,

Review Request 60105: Added helper method recoverSlaveState.

2017-06-15 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu. Bugs: