> On June 21, 2017, 11:42 a.m., Joseph Wu wrote:
> > I agree this makes the finalization logic safer, but I don't see a way to
> > add a `nullptr` to the `ProcessManager::processes` map.
> >
> > `ProcessManager::spawn` is the only location where the `processes` map is
> > inserted, and this
> On June 21, 2017, 11:42 a.m., Joseph Wu wrote:
> > I agree this makes the finalization logic safer, but I don't see a way to
> > add a `nullptr` to the `ProcessManager::processes` map.
> >
> > `ProcessManager::spawn` is the only location where the `processes` map is
> > inserted, and this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60252/#review178603
---
Patch looks great!
Reviews applied: [60252]
Passed command:
> On June 21, 2017, 11:42 a.m., Joseph Wu wrote:
> > I agree this makes the finalization logic safer, but I don't see a way to
> > add a `nullptr` to the `ProcessManager::processes` map.
> >
> > `ProcessManager::spawn` is the only location where the `processes` map is
> > inserted, and this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60252/#review178522
---
Ship it!
I agree this makes the finalization logic safer, but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60252/
---
Review request for mesos and Joseph Wu.
Repository: mesos
Description
