----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60282/#review178701 -----------------------------------------------------------
Fix it, then Ship it! "Validation code for operations, and tasks" in commit message: remove the comma. "a `upgradeResources`" in commit message: "a `validateAndUpgradeResources`" src/common/resources_utils.hpp Lines 141 (patched) <https://reviews.apache.org/r/60282/#comment252854> "in their previous format" => "unchanged". - Neil Conway On June 21, 2017, 7:07 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60282/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 7:07 p.m.) > > > Review request for mesos and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Validation code for operations, and tasks validated the resources as > the first step, and assumed valid resources from then on. This means > that it started to use functions such as `isDynamicallyReserved`. > > However, since `isDynamicallyReserved` requires the resources to be > in the "post-reservation-refinement" format, we must convert the > resources before using those functions. For now, we introduce > a `upgradeResources` abstraction which is called to validate and > convert the resources before invoking operation / task validation. > > > Diffs > ----- > > src/common/resources_utils.hpp 4b033687fa7224ffa36523cb3ca366f4384fd4f8 > src/common/resources_utils.cpp 751194c5ff5c794c77be3bcf16892af39de6d4d9 > > > Diff: https://reviews.apache.org/r/60282/diff/3/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
