Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-23 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review181184
---


Fix it, then Ship it!




I left some comments, but will make the changes myself and commit without 
another iteration.
As part of this I am also adding `tox` to the `cli_new` `pip-requirements.txt` 
file.


src/python/.gitignore
Lines 2-4 (patched)


I will pull this into a spearate commit when I commit this.



src/python/lib/tests/test_mesos.py
Lines 18 (patched)


Misspelled. I will fix this myself as I commit this.


- Kevin Klues


On July 20, 2017, 6:45 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 20, 2017, 6:45 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package.
> tox.ini is added under the same dir to enable automated unit tests via the 
> command `tox`,
> which run tests via pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   src/python/lib/tests/test_mesos.py PRE-CREATION 
>   src/python/lib/tox.ini PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/9/
> 
> 
> Testing
> ---
> 
> 1. install tox
> 2. cd src/python/lib
> 3. tox
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-20 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 20, 2017, 6:45 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

remove unused import and add tox.ini


Repository: mesos


Description (updated)
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package.
tox.ini is added under the same dir to enable automated unit tests via the 
command `tox`,
which run tests via pytest.

Review: https://reviews.apache.org/r/60719/


Diffs (updated)
-

  src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 
  src/python/lib/tests/__init__.py PRE-CREATION 
  src/python/lib/tests/test_mesos.py PRE-CREATION 
  src/python/lib/tox.ini PRE-CREATION 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60719/diff/9/

Changes: https://reviews.apache.org/r/60719/diff/8-9/


Testing (updated)
---

1. install tox
2. cd src/python/lib
3. tox


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-20 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review181058
---




src/python/lib/test.sh
Lines 1 (patched)


replace with tox.ini


- Eric Chung


On July 17, 2017, 5:59 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 17, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package
> and to allow tests to be run via `python setup.py test`, which delegates
> tests to pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/test.sh PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   src/python/lib/tests/test_mesos.py PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/8/
> 
> 
> Testing
> ---
> 
> under src/python/lib, run `bash test.sh`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-20 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review181057
---




src/python/lib/setup.py
Lines 21 (patched)


remove


- Eric Chung


On July 17, 2017, 5:59 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 17, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package
> and to allow tests to be run via `python setup.py test`, which delegates
> tests to pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/test.sh PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   src/python/lib/tests/test_mesos.py PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/8/
> 
> 
> Testing
> ---
> 
> under src/python/lib, run `bash test.sh`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review180714
---



Patch looks great!

Reviews applied: [60719]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 17, 2017, 5:59 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 17, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package
> and to allow tests to be run via `python setup.py test`, which delegates
> tests to pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/test.sh PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   src/python/lib/tests/test_mesos.py PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/8/
> 
> 
> Testing
> ---
> 
> under src/python/lib, run `bash test.sh`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-17 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 17, 2017, 5:59 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

Fix linting issues


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.

Review: https://reviews.apache.org/r/60719/


Diffs (updated)
-

  src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 
  src/python/lib/test.sh PRE-CREATION 
  src/python/lib/tests/__init__.py PRE-CREATION 
  src/python/lib/tests/test_mesos.py PRE-CREATION 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60719/diff/8/

Changes: https://reviews.apache.org/r/60719/diff/7-8/


Testing
---

under src/python/lib, run `bash test.sh`


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-17 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 17, 2017, 5:50 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

address comments


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.

Review: https://reviews.apache.org/r/60719/


Diffs (updated)
-

  src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 
  src/python/lib/test.sh PRE-CREATION 
  src/python/lib/tests/__init__.py PRE-CREATION 
  src/python/lib/tests/test_mesos.py PRE-CREATION 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60719/diff/7/

Changes: https://reviews.apache.org/r/60719/diff/6-7/


Testing
---

under src/python/lib, run `bash test.sh`


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-16 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review180640
---




src/python/lib/setup.py
Lines 41 (patched)


s/`Eric Chung`/`Apache Mesos`.



src/python/lib/setup.py
Lines 42 (patched)


s/`cinchu...@gmail.com`/`d...@mesos.apache.org`.


- Armand Grillet


On July 12, 2017, 11:21 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 12, 2017, 11:21 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package
> and to allow tests to be run via `python setup.py test`, which delegates
> tests to pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.cfg PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/test.sh PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/6/
> 
> 
> Testing
> ---
> 
> under src/python/lib, run `bash test.sh`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review180376
---



Patch looks great!

Reviews applied: [60719]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 12, 2017, 11:21 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 12, 2017, 11:21 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package
> and to allow tests to be run via `python setup.py test`, which delegates
> tests to pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.cfg PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/test.sh PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/6/
> 
> 
> Testing
> ---
> 
> under src/python/lib, run `bash test.sh`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-12 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 12, 2017, 11:06 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

use pytest directly instead of using pytest-runner


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.


Diffs (updated)
-

  src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 
  src/python/lib/test.sh PRE-CREATION 
  src/python/lib/tests/__init__.py PRE-CREATION 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60719/diff/5/

Changes: https://reviews.apache.org/r/60719/diff/4-5/


Testing (updated)
---

under src/python/lib, run `bash test.sh`


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-12 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 12, 2017, 11:21 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Repository: mesos


Description (updated)
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.

Review: https://reviews.apache.org/r/60719/


Diffs (updated)
-

  src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 
  src/python/lib/test.sh PRE-CREATION 
  src/python/lib/tests/__init__.py PRE-CREATION 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60719/diff/6/

Changes: https://reviews.apache.org/r/60719/diff/5-6/


Testing
---

under src/python/lib, run `bash test.sh`


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review180367
---



Patch looks great!

Reviews applied: [60719]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 7, 2017, 9:44 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> ---
> 
> (Updated July 7, 2017, 9:44 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package
> and to allow tests to be run via `python setup.py test`, which delegates
> tests to pytest.
> 
> 
> Diffs
> -
> 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.cfg PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/4/
> 
> 
> Testing
> ---
> 
> 1. under src/python/lib, run `virtualenv env`
> 2. `. env/bin/activate`
> 3. `pip install setuptools --upgrade`
> 4. `python setup.py test`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-12 Thread Eric Chung 


> On July 9, 2017, 9:10 a.m., Armand Grillet wrote:
> > I have not been able to reproduce the steps to test the patch, the last one 
> > returns this error:
> > ```
> > (env) lib (60719) $ python setup.py test
> > zip_safe flag not set; analyzing archive contents...
> > 
> > Installed 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_runner-2.11.1-py2.7.egg
> > /Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/dist.py:336:
> >  UserWarning: Normalizing '0.0.0.dev' to '0.0.0.dev0'
> >   normalized_version,
> > running pytest
> > Searching for pytest-cov
> > Reading https://pypi.python.org/simple/pytest-cov/
> > Downloading 
> > https://pypi.python.org/packages/24/b4/7290d65b2f3633db51393bdf8ae66309b37620bc3ec116c5e357e3e37238/pytest-cov-2.5.1.tar.gz#md5=5acf38d4909e19819eb5c1754fbfc0ac
> > Best match: pytest-cov 2.5.1
> > Processing pytest-cov-2.5.1.tar.gz
> > Writing 
> > /var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-zEq9cm/pytest-cov-2.5.1/setup.cfg
> > Running pytest-cov-2.5.1/setup.py -q bdist_egg --dist-dir 
> > /var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-zEq9cm/pytest-cov-2.5.1/egg-dist-tmp-CB8boX
> > warning: no files found matching '.isort.cfg'
> > warning: no files found matching '.pylintrc'
> > warning: no previously-included files matching '*.py[cod]' found anywhere 
> > in distribution
> > warning: no previously-included files matching '__pycache__' found anywhere 
> > in distribution
> > warning: no previously-included files matching '*.so' found anywhere in 
> > distribution
> > creating 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
> > Extracting pytest_cov-2.5.1-py2.7.egg to 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs
> > 
> > Installed 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
> > Searching for pytest
> > Downloading 
> > https://pypi.python.org/packages/24/b4/7290d65b2f3633db51393bdf8ae66309b37620bc3ec116c5e357e3e37238/pytest-cov-2.5.1.tar.gz#md5=5acf38d4909e19819eb5c1754fbfc0ac
> > Best match: pytest cov-2.5.1
> > Processing pytest-cov-2.5.1.tar.gz
> > Writing 
> > /var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-bfwvC6/pytest-cov-2.5.1/setup.cfg
> > Running pytest-cov-2.5.1/setup.py -q bdist_egg --dist-dir 
> > /var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-bfwvC6/pytest-cov-2.5.1/egg-dist-tmp-ss6Ebd
> > warning: no files found matching '.isort.cfg'
> > warning: no files found matching '.pylintrc'
> > warning: no previously-included files matching '*.py[cod]' found anywhere 
> > in distribution
> > warning: no previously-included files matching '__pycache__' found anywhere 
> > in distribution
> > warning: no previously-included files matching '*.so' found anywhere in 
> > distribution
> > removing 
> > '/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg'
> >  (and everything under it)
> > creating 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
> > Extracting pytest_cov-2.5.1-py2.7.egg to 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs
> > 
> > Installed 
> > /Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
> > Traceback (most recent call last):
> >   File "setup.py", line 63, in 
> > zip_safe=False,
> >   File 
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py",
> >  line 151, in setup
> > dist.run_commands()
> >   File 
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py",
> >  line 953, in run_commands
> > self.run_command(cmd)
> >   File 
> > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py",
> >  line 972, in run_command
> > cmd_obj.run()
> >   File "build/bdist.macosx-10.12-intel/egg/ptr.py", line 150, in run
> >   File "build/bdist.macosx-10.12-intel/egg/ptr.py", line 133, in _super_run
> >   File 
> > "/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/command/test.py",
> >  line 199, in run
> > installed_dists = self.install_dists(self.distribution)
> >   File "build/bdist.macosx-10.12-intel/egg/ptr.py", line 91, in 
> > install_dists
> >   File 
> > "/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/command/test.py",
> >  line 195, in install_dists
> > tr_d = dist.fetch_build_eggs(dist.tests_require or [])
> >   File 
> > "/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/dist.py",
> >  line 377, in fetch_build_eggs
> > replace_conflicting=True,
> >   File 
> > "/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/pkg_resources/__init__.py",
> >  line 855, in resolve
> > raise DistributionNotFound(req, requirers)
> > pkg_resources.DistributionNotFound: The

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-09 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review179995
---



I have not been able to reproduce the steps to test the patch, the last one 
returns this error:
```
(env) lib (60719) $ python setup.py test
zip_safe flag not set; analyzing archive contents...

Installed 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_runner-2.11.1-py2.7.egg
/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/dist.py:336:
 UserWarning: Normalizing '0.0.0.dev' to '0.0.0.dev0'
  normalized_version,
running pytest
Searching for pytest-cov
Reading https://pypi.python.org/simple/pytest-cov/
Downloading 
https://pypi.python.org/packages/24/b4/7290d65b2f3633db51393bdf8ae66309b37620bc3ec116c5e357e3e37238/pytest-cov-2.5.1.tar.gz#md5=5acf38d4909e19819eb5c1754fbfc0ac
Best match: pytest-cov 2.5.1
Processing pytest-cov-2.5.1.tar.gz
Writing 
/var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-zEq9cm/pytest-cov-2.5.1/setup.cfg
Running pytest-cov-2.5.1/setup.py -q bdist_egg --dist-dir 
/var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-zEq9cm/pytest-cov-2.5.1/egg-dist-tmp-CB8boX
warning: no files found matching '.isort.cfg'
warning: no files found matching '.pylintrc'
warning: no previously-included files matching '*.py[cod]' found anywhere in 
distribution
warning: no previously-included files matching '__pycache__' found anywhere in 
distribution
warning: no previously-included files matching '*.so' found anywhere in 
distribution
creating 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
Extracting pytest_cov-2.5.1-py2.7.egg to 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs

Installed 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
Searching for pytest
Downloading 
https://pypi.python.org/packages/24/b4/7290d65b2f3633db51393bdf8ae66309b37620bc3ec116c5e357e3e37238/pytest-cov-2.5.1.tar.gz#md5=5acf38d4909e19819eb5c1754fbfc0ac
Best match: pytest cov-2.5.1
Processing pytest-cov-2.5.1.tar.gz
Writing 
/var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-bfwvC6/pytest-cov-2.5.1/setup.cfg
Running pytest-cov-2.5.1/setup.py -q bdist_egg --dist-dir 
/var/folders/mt/n_tlp88537s9kt9n9173_mdhgn/T/easy_install-bfwvC6/pytest-cov-2.5.1/egg-dist-tmp-ss6Ebd
warning: no files found matching '.isort.cfg'
warning: no files found matching '.pylintrc'
warning: no previously-included files matching '*.py[cod]' found anywhere in 
distribution
warning: no previously-included files matching '__pycache__' found anywhere in 
distribution
warning: no previously-included files matching '*.so' found anywhere in 
distribution
removing 
'/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg'
 (and everything under it)
creating 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
Extracting pytest_cov-2.5.1-py2.7.egg to 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs

Installed 
/Users/Armand/Code/apache-mesos/src/python/lib/.eggs/pytest_cov-2.5.1-py2.7.egg
Traceback (most recent call last):
  File "setup.py", line 63, in 
zip_safe=False,
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py",
 line 151, in setup
dist.run_commands()
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py",
 line 953, in run_commands
self.run_command(cmd)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py",
 line 972, in run_command
cmd_obj.run()
  File "build/bdist.macosx-10.12-intel/egg/ptr.py", line 150, in run
  File "build/bdist.macosx-10.12-intel/egg/ptr.py", line 133, in _super_run
  File 
"/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/command/test.py",
 line 199, in run
installed_dists = self.install_dists(self.distribution)
  File "build/bdist.macosx-10.12-intel/egg/ptr.py", line 91, in install_dists
  File 
"/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/command/test.py",
 line 195, in install_dists
tr_d = dist.fetch_build_eggs(dist.tests_require or [])
  File 
"/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/setuptools/dist.py",
 line 377, in fetch_build_eggs
replace_conflicting=True,
  File 
"/Users/Armand/Code/apache-mesos/src/python/lib/env/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 855, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pytest' distribution was not found and 
is required by the application
```
I woud suggest following an installation process similar to the one for 
`cli_new` using a bootstrap script to avoid this. 
A new `.gitignore` or an

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-07 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 7, 2017, 9:44 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

Add src/python/lib to mesos-style.py; fix lint errors.


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.


Diffs (updated)
-

  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60719/diff/4/

Changes: https://reviews.apache.org/r/60719/diff/3-4/


Testing
---

1. under src/python/lib, run `virtualenv env`
2. `. env/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-07 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 7, 2017, 9:32 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

add .dev suffix to __version__


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.


Diffs (updated)
-

  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 


Diff: https://reviews.apache.org/r/60719/diff/3/

Changes: https://reviews.apache.org/r/60719/diff/2-3/


Testing
---

1. under src/python/lib, run `virtualenv env`
2. `. env/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`


Thanks,

Eric Chung

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-07 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

(Updated July 7, 2017, 9:30 p.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Changes
---

remove unnecessary comment


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.


Diffs (updated)
-

  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 


Diff: https://reviews.apache.org/r/60719/diff/2/

Changes: https://reviews.apache.org/r/60719/diff/1-2/


Testing
---

1. under src/python/lib, run `virtualenv env`
2. `. env/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`


Thanks,

Eric Chung

Review Request 60719: Add test infrastructure for src/python/lib/mesos.

2017-07-07 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/
---

Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Repository: mesos


Description
---

Part of MESOS-7310, this patch adds the test infrastructure necessary
for reliably running unit tests for the mesos package located under
src/python/lib.

setup.py is added under src/python/lib to both define the Python package
and to allow tests to be run via `python setup.py test`, which delegates
tests to pytest.


Diffs
-

  src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  src/python/lib/requirements-test.in PRE-CREATION 
  src/python/lib/requirements.in PRE-CREATION 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py PRE-CREATION 


Diff: https://reviews.apache.org/r/60719/diff/1/


Testing
---

1. under src/python/lib, run `virtualenv env`
2. `. env/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`


Thanks,

Eric Chung