Re: Review Request 61818: Adjusted a comment and a log message around container termination.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61818/#review209384
---
Bad patch!
Reviews applied: [61818]
Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 61818
Error:
2018-10-09 21:40:59 URL:https://reviews.apache.org/r/61818/diff/raw/
[1537/1537] -> "61818.patch" [1]
Traceback (most recent call last):
File "support/apply-reviews.py", line 453, in
main()
File "support/apply-reviews.py", line 448, in main
reviewboard(options)
File "support/apply-reviews.py", line 438, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 166, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 257, in commit_patch
data = patch_data(options)
File "support/apply-reviews.py", line 304, in patch_data
return reviewboard_data(options)
File "support/apply-reviews.py", line 346, in reviewboard_data
review = url_to_json(review_api_url(review_id)).get('review_request')
File "support/apply-reviews.py", line 98, in url_to_json
return json.loads(json_str.read())
File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23468/console
- Mesos Reviewbot
On Oct. 9, 2018, 3:50 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61818/
> ---
>
> (Updated Oct. 9, 2018, 3:50 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> When the container launch is aborted and the container is
> cleaned up in the containerizer before `executorLaunched()` is
> invoked, `containerizer->wait()` called in `executorLaunched()`
> does not hold a termination object. This case should not be
> logged as an error.
>
>
> Diffs
> -
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61818/diff/1/
>
>
> Testing
> ---
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/#review209374 --- PASS: Mesos patch 61818 was successfully built and tested. Reviews applied: `['61818']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2441/mesos-review-61818 - Mesos Reviewbot Windows On Oct. 9, 2018, 3:50 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61818/ > --- > > (Updated Oct. 9, 2018, 3:50 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > When the container launch is aborted and the container is > cleaned up in the containerizer before `executorLaunched()` is > invoked, `containerizer->wait()` called in `executorLaunched()` > does not hold a termination object. This case should not be > logged as an error. > > > Diffs > - > > src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a > > > Diff: https://reviews.apache.org/r/61818/diff/1/ > > > Testing > --- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/ --- (Updated Oct. 9, 2018, 3:50 p.m.) Review request for mesos, Gilbert Song, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos Description --- When the container launch is aborted and the container is cleaned up in the containerizer before `executorLaunched()` is invoked, `containerizer->wait()` called in `executorLaunched()` does not hold a termination object. This case should not be logged as an error. Diffs - src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a Diff: https://reviews.apache.org/r/61818/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/#review183635 --- Patch looks great! Reviews applied: [61811, 59746, 61818] Logs available here: http://104.210.40.105/logs/master/61818 - Mesos Reviewbot Windows On Aug. 22, 2017, 5:18 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61818/ > --- > > (Updated Aug. 22, 2017, 5:18 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > --- > > When the container launch is aborted and the container is > cleaned up in the containerizer before `executorLaunched()` is > invoked, `containerizer->wait()` called in `executorLaunched()` > does not hold a termination object. This case should not be > logged as an error. > > > Diffs > - > > src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a > > > Diff: https://reviews.apache.org/r/61818/diff/1/ > > > Testing > --- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/#review183599 --- Patch looks great! Reviews applied: [61811, 59746, 61818] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 22, 2017, 5:18 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61818/ > --- > > (Updated Aug. 22, 2017, 5:18 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > --- > > When the container launch is aborted and the container is > cleaned up in the containerizer before `executorLaunched()` is > invoked, `containerizer->wait()` called in `executorLaunched()` > does not hold a termination object. This case should not be > logged as an error. > > > Diffs > - > > src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a > > > Diff: https://reviews.apache.org/r/61818/diff/1/ > > > Testing > --- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
Review Request 61818: Adjusted a comment and a log message around container termination.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61818/ --- Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu. Repository: mesos Description --- When the container launch is aborted and the container is cleaned up in the containerizer before `executorLaunched()` is invoked, `containerizer->wait()` called in `executorLaunched()` does not hold a termination object. This case should not be logged as an error. Diffs - src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a Diff: https://reviews.apache.org/r/61818/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov
