Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review185021 --- Could you just update the description with some info about the spe

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review185019 --- Ship it! Ship It! - Greg Mann On Sept. 7, 2017, 6:09 p.m., G

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184871 --- ERROR: Failed to apply patch 61920. Please check http://dcos-win.

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/ --- (Updated Sept. 7, 2017, 6:09 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184850 --- ERROR: Failed to apply patch 61920. Please check http://dcos-win.

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184847 --- I think this needs a rebase; I got a conflict in 'slave_authoriza

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184400 --- Patch looks great! Reviews applied: [61920, 61921, 61982, 62042]

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-01 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184396 --- Ship it! - Joerg Schad On Sept. 1, 2017, 9:27 p.m., Gastón Kl

Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-01 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad. Bugs: M